fix(store): realpath:false to prevent ENOENT after stale lock cleanup (Issue #670)#748
Open
jlin53882 wants to merge 1 commit intoCortexReach:masterfrom
Open
fix(store): realpath:false to prevent ENOENT after stale lock cleanup (Issue #670)#748jlin53882 wants to merge 1 commit intoCortexReach:masterfrom
jlin53882 wants to merge 1 commit intoCortexReach:masterfrom
Conversation
… (Issue CortexReach#670) - Add realpath:false to proper-lockfile.lock() to prevent ENOENT when proactive cleanup deletes a stale lock artifact before lock() resolves the canonical path (proper-lockfile v4 default calls fs.realpath()) - Add 2 tests covering the Issue CortexReach#670 scenario: * store() succeeds when lock artifact was already deleted * store() succeeds after ELOCKED recovery cleaned up stale artifact - Scope: intentionally minimal — realpath:false is the complete fix. ELOCKED/ENOTDIR recovery logic is separate (can be follow-up PR). - Pre-existing test failure (cleans up lock artifact after release) is unrelated to this change and was failing before this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #670: ENOENT from proper-lockfile realpath() after proactive stale lock cleanup
Root cause: proper-lockfile v4 defaults to , which calls on the lock file path. When the proactive cleanup (from PR #626) deletes a stale lock artifact, a concurrent call can hit on a file that no longer exists → ENOENT.
Fix: Add to options. This completely bypasses and has zero side effects for the lock file use case.
Changes
realpath: falsein lockfile.lock() optionsTest results
Design notes
cleans up lock artifact after release) is unrelated to this change and was failing before this PRReferences