-
Notifications
You must be signed in to change notification settings - Fork 714
feat(dreaming-engine-v2): add dreaming engine with scope isolation and embedded reflections #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlin53882
wants to merge
10
commits into
CortexReach:master
Choose a base branch
from
jlin53882:fix/dreaming-engine-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a16b87d
feat: dreaming engine with scope isolation, embedded reflections, and…
helal-muneer 47a870a
fix: resolve workspace dir to workspace-main for DREAMS.md
helal-muneer ca29227
fix: discover all scopes from store for dreaming, not just defined sc…
helal-muneer d080777
fix: wire AccessTracker so recall operations update access_count
helal-muneer 12a11b8
fix: address all reviewer feedback from PR #672 second review
helal-muneer 88fe4be
fix: address all third-review feedback from rwmjhb on PR #672
helal-muneer 24209a0
fix: address all fourth-review feedback from rwmjhb on PR #672
helal-muneer c60764f
feat: add active memory runtime registration with feature-detect
jlin53882 26da5b4
fix(ci): register dreaming-engine test — Issue #565/#571/#577
jlin53882 1bdd77f
fix(ci): sync EXPECTED_BASELINE with CI_TEST_MANIFEST (adds 4 missing…
jlin53882 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the service stops after a manual recall has scheduled a debounced access-count write, this
accessTrackeridentifier is not in theregister()closure—the tracker is created as a local inside_initPluginState()and is not returned inPluginSingletonState. The resultingReferenceErroris caught by the surrounding cleanupcatch, so the tracker is never destroyed and its timer/pending writes can outlive plugin stop or re-registration.Useful? React with 👍 / 👎.