Repository navigation
Add Sculpt-style Slice editing and precise camera parity - #93
Merged
Merged
Conversation
…-panel-and-toggle-them-like-github-files-stay-on-the-left-edit-shows-first-below
…l-and-toggle-them-like-github-files-stay-on-the-left-edit-shows-first-below verification
…ity-with-unrestricted-orbit-and-screen-space-pan
…ith-unrestricted-orbit-and-screen-space-pan verification
…-panel-and-toggle-them-like-github-files-stay-on-the-left-edit-shows-first-below
…l-and-toggle-them-like-github-files-stay-on-the-left-edit-shows-first-below verification
…vidence-for-the-approved-archive
…ce-for-the-approved-archive verification
…ity-with-unrestricted-orbit-and-screen-space-pan
…ith-unrestricted-orbit-and-screen-space-pan verification
…-panel-and-toggle-them-like-github-files-stay-on-the-left-edit-shows-first-below
…l-and-toggle-them-like-github-files-stay-on-the-left-edit-shows-first-below verification
…vidence-for-the-approved-archive
…ce-for-the-approved-archive verification
…er-with-a-visual-grid-drawing-tools-undo-and-live-3d-reference
…th-a-visual-grid-drawing-tools-undo-and-live-3d-reference verification
…-and-precise-camera-steps-to-sculpt-and-the-viewer
…precise-camera-steps-to-sculpt-and-the-viewer verification
…er-with-a-visual-grid-drawing-tools-undo-and-live-3d-reference
…th-a-visual-grid-drawing-tools-undo-and-live-3d-reference verification
…-and-precise-camera-steps-to-sculpt-and-the-viewer
…precise-camera-steps-to-sculpt-and-the-viewer verification
…after-view-and-display-size-changes-while-retaining-the-webgl-context-and-camera
…-view-and-display-size-changes-while-retaining-the-webgl-context-and-camera verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching files discarded drafts, and the cube camera stopped at the poles. Preserve each file and linked-entry draft, caret and selected plane. Search, packing, sharing and downloads use the current source; filtering, keyboard navigation and phone document reveal follow the active draft.
Add a Sculpt-style Slice workspace beside Edit, Preview and Cubes. Select a thumbnail, Draw/Erase/Fill with Sculpt’s palette and 1/3/5 brushes, move the selected cell with arrows, apply with Space or exact X/Y, zoom the grid and show the previous slice. Fast strokes have no gaps, a drag is one undo step, and undo/redo also covers source edits. The live 3D reference shares the existing WebGL canvas; Expand returns to Cubes with the same camera and slice.
Slice edits replace only targeted grid characters and preserve surrounding source, CRLF, labels, plane coordinates and other slices. Unsupported documents retain source editing with guidance. The edit profile is complete rectangular grids up to 64×64, 256 planes, 4000 occupied cells and 1.5 MiB source. History is bounded to 100 snapshots per draft and 8 MiB across the collection; rejected over-budget strokes roll back completely. Structural slice actions, resizing and browser 3D painting remain future work.
Match Sculpt and browser camera movement: full-turn orbit through the poles, screen-space pan, proportional zoom, Fit, colored X/Y/Z rotation rings, Free/axis-constrained dragging, degree nudges (default 15°) and pan nudges (default 0.25 cells). Native ASCII, scalar and live GPU projections and nearest picking use the same rotated basis. Camera-only changes retain geometry and document history. Shared asymmetric fixtures use independent expected rows and rotation matrices to verify native/browser editing, projection and picking.
Repair the blurry Cubes regression caused by freezing the shared canvas bitmap at its initial small size. In the actual in-app browser, a 368×322 bitmap stretched across a 1099×911 stage. The drawable now follows the pane size and display density, preserving the same WebGL context, program, geometry, source, camera and selection. Resize only changed dimensions, retain the proportional 2048-edge/2x bounds, and rearm the density media query for display changes without CSS resizing. Actual repaired bitmap and display both measured 1099×911.
Validation:
8e9a0c4: complete macOS UI 226 passed; Linux CI UI 218 passed with eight existing platform-snapshot skips; configured native selection 637 passed and final parity selection 11 passed. Shared fixtures compare actual native edits and browser gestures with independent expected rows and camera matrices. Native source is unchanged by the blur repair.Actual screenshots, measurements, test logs and implementation digests: drawable repair evidence and Slice/camera evidence. The original user draft/history stays in its original browser tab; the corrected preview copied its current source.
Leif directly approved Slice/camera scope and verified closure. The narrow blur repair applies Leif’s standing direct request to improve browser quality and fix this PR; its approval/review records identify the executing agent:codex and do not claim a fresh human definition approval, Leif diff review, independent review or permitted signature. Actual unsigned Codex provenance remains separate from the unchanged strict permitted-signature/reviewer policy. Trust’s configured soft provenance policy remains intact. Leif retains merge authority.
Pinned Trust passed at blur implementation
95c1213886b853a7b945fd833a5af02fa0f8128d, with Augur review at risk 36 and progressive provenance degradation. Final archive head78a94d05da1d21fdbf397cb976546e5d4cc67c2bhas byte-identical HTML and browser tests; only synchronized specifications, verification evidence and lifecycle metadata follow the tested implementation. Final strict specs passed with zero warnings and complete configured coverage. This does not claim a second full Trust run on the archive head.The blur repair passed supported scoped check/review/finalize and is archived with the previous approved Slice/camera changes. Its receipts identify agent:codex. Actual unsigned attestations for the blur implementation and archive head are published in the normal Attest notes ref; the unchanged strict permitted-signature/reviewer policy rejects them. Remote checks for this newly published head are pending.