This repository was archived by the owner on Jul 2, 2026. It is now read-only.
Repository navigation
chore: extract marketplace schemas into domain-colocated file - #1137
Closed
corvid-agent wants to merge 3 commits into
Closed
corvid-agent wants to merge 3 commits into
corvid-agent wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
First incremental step of schema decomposition: move marketplace, pricing tier, and trial Zod schemas from the monolithic validation.ts into server/lib/schemas/marketplace.ts. Re-export from validation.ts for backward compatibility. Update marketplace route to import directly from the new location. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Move the parent task existence check before the network call to fetchPrBody in createVerificationTasks. This avoids unnecessary gh CLI calls when the parent task doesn't exist and fixes the CI timeout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Superseded by #1139 which has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First incremental PR for #1134 — decompose
server/lib/validation.tsinto domain-colocated Zod schema files.server/lib/schemas/marketplace.tsvalidation.tsfor full backward compatibility — no consumer changes requiredserver/routes/marketplace.tsto import directly from the new location (demonstrates target pattern)specs/lib/infra.spec.mdwith new file and schema documentationApproach
server/lib/schemas/is the new home for domain-colocated schemas. This avoids converting flat route files into directories and stays within the establishedserver/lib/convention. Future PRs will extract additional domains (schedules, workflows, agents, etc.) following this same pattern.Validation
bun x tsc --noEmit --skipLibCheck— passesbun test— 7375 pass, 0 failbun run spec:check— 146/146 specs, 384/384 file coverage (100%)Test plan
🤖 Generated with Claude Code