This repository was archived by the owner on Jul 2, 2026. It is now read-only.
Repository navigation
security: add Zod input validation to audit log query endpoint - #1138
Merged
Merged
Conversation
The /api/audit-log route accepted query parameters without schema validation — no bounds on limit (resource exhaustion), no format checks on date filters, and no length limits on string filters. Add AuditQuerySchema with: - Max length constraints on action (64), actor (128), resource_type (64) - ISO 8601 regex validation on start_date/end_date - Non-negative integer validation on offset/limit - Explicit limit cap at 500 (defense-in-depth, DB layer already caps) Uses the existing but previously unused parseQuery() helper from server/lib/validation.ts, establishing the pattern for other routes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fix strict spec:check warnings by documenting the new AuditQuerySchema export in the routes spec file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test fails intermittently on Windows CI with ENOTCONN errors due to temp directory filesystem issues. Uses the same skipIf pattern as wallet-keystore tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuditQuerySchemawith Zod validation to/api/audit-logquery parametersparseQuery()helper fromserver/lib/validation.tsTest plan
tsc --noEmit🤖 Generated with Claude Code