Skip to content

Test infra: mocking harness + $HOME isolation + publish coverage #447

Description

@0xLeif

Three related test-quality gaps:

  • No mocking harness — every network/subprocess path (LLM HTTP, GitHub API, remote fetch, plugin install, work git flows) is untested.
  • Tests inherit the real environment — cli_config_init_default can write a real ~/.config/fledge/config.toml and asserts nothing; doctor tests probe the network. Tests should set FLEDGE_CONFIG_DIR/HOME to a tempdir and stub the network.
  • src/publish.rs test module is tautological — the only real test is an empty #[ignore] stub, leaving the GitHub publish path with zero coverage.

Filed from a skeptical staff-level review (Medium-severity tier). All Critical/High findings and the correctness/doc Medium findings were fixed in #432–442.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions