Skip to content

Update: generated agent skills for SpecSync 6.0 check-is-product lifecycle - #777

Merged
corvid-agent merged 7 commits into
mainfrom
leif/specsync-6-skills
Sep 10, 2026
Merged

corvid-agent merged 7 commits into
mainfrom
leif/specsync-6-skills

Conversation

@0xLeif

@0xLeif 0xLeif commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Generated Claude/Cursor/Codex/Gemini skills now lead with specsync check as the product and SDD as opt-in via specsync change adopt.
  • Happy path in skill and command templates: approve --actor → check --commit → review --reviewer → ship/finalize. v1 start/verify/accept/archive are labeled recovery only.
  • AGENT_ARTIFACT_TEMPLATE_VERSION 5 so specsync agents install refreshes managed artifacts.
  • Adds REQ-agents-007 and a tracked-file pin test.

Test Plan

  • cargo test agents:: (42 passed)
  • specsync check --strict agents
  • specsync change check --commit on teach-generated-agent-skills-the-specsync-6-0-check-is-product-lifecycle

Out of scope: hooks.rs snippets (separate installer), catalog skill (CorvidLabs/skills#17), new slash commands for ship/status/adopt/review.

@0xLeif
0xLeif requested a review from a team as a code owner September 10, 2026 03:20
@0xLeif
0xLeif requested review from 0xGaspar, Kyntrin and tofu-ux and removed request for a team September 10, 2026 03:20
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-09-10T04:09:41.561229Z 9fe7f7f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad5181cd17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents.rs Outdated
Comment thread src/agents.rs Outdated
Comment thread src/agents.rs Outdated
github-actions[bot]
github-actions Bot previously approved these changes Sep 10, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Your code sparkles like a dropped french fry."

CI Summary

Check Status
Validate action.yml ✅ Passed
Packaged Action Consumer ✅ Passed
Dependency Audit ✅ Passed
Code Coverage ✅ Passed
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ✅ Passed
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 62
Passed 62
Errors 0
Warnings 0
File coverage 100% (107/107)
LOC coverage 100% (148539/148539)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

0xLeif commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Addressed Codex review on 6a16689a:

  • Pre-PR checklist no longer records review/ship before the PR exists. Review and ship stay after the product tip is on the PR and required checks have run.
  • Create-change command template now names change adopt, approve --actor, and review --reviewer.
  • Generated skill lists Cursor's flat slash names (/specsync-create-change, etc.) next to Claude/Gemini /specsync:... names.

@github-actions
github-actions Bot dismissed their stale review September 10, 2026 03:41

Superseded by updated review.

github-actions[bot]
github-actions Bot previously approved these changes Sep 10, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Found a shiny new spec!"

CI Summary

Check Status
Validate action.yml ✅ Passed
Packaged Action Consumer ✅ Passed
Dependency Audit ✅ Passed
Code Coverage ✅ Passed
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ✅ Passed
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 62
Passed 62
Errors 0
Warnings 0
File coverage 100% (107/107)
LOC coverage 100% (148547/148547)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

@corvid-agent corvid-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoS exact-head COMMENT on tip 6a16689a (generated agent skills / check-is-product for SpecSync 6.0).

CI full green on this tip including Lifecycle, coverage, and Required CI gate. Zero prior CoS review on the tip SHA.

Looks landable after SpecSync sequence — parent APPROVE + squash once #778 settles (or land independently if stack order allows; SpecSync squash-only either way). Tip-move from ad5181cd retired the wait-CI hold.

@corvid-agent corvid-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE exact tip 6a16689a — Required CI / Lifecycle / Trust / coverage all green. Stack preference still #778 first when that tip’s CI settles (tip moved to 3c1bc380; archive follow-ups noted on-thread). CoS will squash #777 after #778 when both are APPROVED + settled.

@corvid-agent corvid-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE exact tip 6a16689ac3af285886731e60dd53458a950027bd — Required CI green. Prefer squash after #778 when that tip settles + APPROVED.

@corvid-agent corvid-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE exact tip 6a16689ac3af285886731e60dd53458a950027bd — Required CI green. Prefer squash after #778 when that tip settles + APPROVED.

@0xLeif
0xLeif force-pushed the leif/specsync-6-skills branch from 6a16689 to 9fe7f7f Compare September 10, 2026 04:09
…eview

Finalize on PR #777 — changes/ empty; archive under 2026-09-10-teach-generated-agent-skills-the-specsync-6-0-check-is-product-lifecycle.

@corvid-agent corvid-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMENT archive tip a8e6f17b — CoS ran SpecSync 6.0 scoped review (corvid-agent pass) + finalize on existing checkout; .specsync/changes/ empty; archive 2026-09-10-teach-generated-agent-skills-the-specsync-6-0-check-is-product-lifecycle. Same-actor pushed this tip → CoS cannot binding-APPROVE. Waiting Required CI + parent/gha APPROVE then squash.

@github-actions
github-actions Bot dismissed their stale review September 10, 2026 04:13

Superseded by updated review.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Corvin says...

      _
    <(;\  .oO(oh no...)
     |/(\
      \(\\
      " "\\

"Even the dumpster of code seems empty today."

CI Summary

Check Status
Validate action.yml ✅ Passed
Packaged Action Consumer ✅ Passed
Dependency Audit ❌ cancelled
Code Coverage ❌ cancelled
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ❌ cancelled
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 62
Passed 62
Errors 0
Warnings 0
File coverage 100% (107/107)
LOC coverage 100% (148547/148547)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

@corvid-agent
corvid-agent dismissed github-actions[bot]’s stale review September 10, 2026 04:27

Stale CR from cancelled mid-push CI; Required CI now full green on a8e6f17

@corvid-agent
corvid-agent merged commit 15e53ca into main Sep 10, 2026
21 checks passed
@corvid-agent
corvid-agent deleted the leif/specsync-6-skills branch September 10, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants