Repository navigation
Conversation
…ssets-in-canonical-change-evidence-without-hiding-content-changes
…-in-canonical-change-evidence-without-hiding-content-changes verification
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Looking sharp! Like a beak should be."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Human intent check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (build, test, clippy) | ✅ Passed |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
✅ SpecSync: Passed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 0 |
| Warnings | 0 |
| File coverage | 100% (107/107) |
| LOC coverage | 100% (149594/149594) |
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
…ssets-in-canonical-change-evidence-without-hiding-content-changes
…-in-canonical-change-evidence-without-hiding-content-changes verification
github-actions
Bot
dismissed
their stale review
September 30, 2026 20:10
Superseded by updated review.
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Caw! Your code sparkles like a dropped french fry."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Human intent check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (build, test, clippy) | ✅ Passed |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
✅ SpecSync: Passed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 0 |
| Warnings | 0 |
| File coverage | 100% (107/107) |
| LOC coverage | 100% (149594/149594) |
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Fixes #789.
change checkcurrently rejects a repository as soon as canonical workspace evidence encounters a Git LFS filter, even when those assets are unchanged and outside the delivery scope.This change recognizes plain SHA-256 LFS v1 pointers and hashes downloaded asset bytes into the same canonical representation. Asset edits still change the evidence, including assets listed in
ignored_paths; no assets are excluded to make verification pass. Large assets are streamed with bounded memory. Evidence queries disable LFS filters locally, without invoking git-lfs or fetching asset content. Unsupported filters, malformed pointers and pointer extensions remain rejected.Validation
change check --commitpassed and recorded verification on this branch.The approved change-package notes retain the earlier dependency-cache blocker as historical evidence. Bruno subsequently authorized a one-time fetch of locked Cargo dependencies, enabling the local validation above; current results are tracked in the living module specs.
Review
The two human-intent criteria were explicitly confirmed by Bruno. Human implementation review and same-PR SpecSync finalization are still pending; no review approval or merge readiness is claimed. Standard LFS pointers are supported; extension-based transformations remain out of scope. Hashing downloaded assets requires reading their contents, so I/O scales with asset size.