Repository navigation
Audio I/O Fixes - #17
Merged
CorvusPrudens merged 2 commits intoMar 23, 2026
Merged
Conversation
…on seed1.1 (rev5) and patch sm
Owner
<3 |
CorvusPrudens
merged commit Mar 23, 2026
ce69ed8
into
CorvusPrudens:sample-rate
5 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to resolve ongoing channel-swap issues, and the distortion/buzz on the Seed 1.1/Rev5, and PatchSM.
The global channel-swap was due to the I2S setting: frame_sync_active_high.
In libDaisy C++, and the ST HAL, the "I2S Protocol Init" always leaves this set so that the Frame Sync is active high.
This was causing all channels (input and output) two be swapped from the expectation.
An ongoing secondary issue (that likely made the above issue more confusing) is that the Rev5 and Patch SM audio outputs were not swapped, but the inputs were distorted due to a single-sample not being updated/present in the data seen by the callbacks.
I tried a few order-of-operations changes before just reverting the unique handling of these two unique cases to be more similar to the working configurations, and voila -- everything seems to be working well (no distortion, channels are in the correct order).
I have gone back through and tested each revision of the Seed, the Seed2 DFM, and the Patch SM and it seems like they are all behaving as expected now.
If that's the case, I think we could probably go back later and simplify some of this initialization (e.g. remove the separate AudioStream types, consolidating the non-unique sai/dma startup to code that runs after the variant-specific configuration/initialization).