Repository navigation
remaps PatchSM CV input pins to match documented order in datasheet, … - #19
Merged
CorvusPrudens merged 1 commit intoJun 26, 2026
Merged
Conversation
…C++ API, and patch.init frontpanel.
CorvusPrudens
approved these changes
Jun 26, 2026
CorvusPrudens
merged commit Jun 26, 2026
657768e
into
CorvusPrudens:sample-rate
5 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this was ... weird to figure out.
But basically, what it seems like is that the ADC number mapping that is used elsewhere are remapped into a different order than the pinout implies.
Since all other integrations are either using libDaisy (hvcc, oopsy, etc.), or are modified copies of some of the sources (DaisyDuino) the ADC pins are typically configured at the SOM level and accessed in a separately indexed order.
This order is built in libDaisy with these pin definitions and then reordered for the ADCs.
So in order for consumers of the patch_sm gpio in rust to have a consistent experience, we need to similarly remap these pins. I chose to do this directly at the GPIO mapping to keep it simplest, and added multiple comments to explain the oddity.