Conversation
M-W-K
previously approved these changes
Sep 2, 2026
M-W-K
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, though question -- why are you implementing casing through a block property instead of through separate blocks and the Create interface and registry, like how Create handles encasing?
Contributor
Author
|
There's no specific reason, I wasn't familiar with how Create worked, but I'll definitely have to change it. I hope to fix it soon |
Contributor
Author
|
I've worked out this idea, however, I don't see how the train casing can be connected to other train casing blocks due to its internal system. Nevertheless, the possibility exists and it could be useful |
M-W-K
reviewed
Sep 9, 2026
| .block("brass_encased_rcs_thruster", | ||
| properties -> new EncasedRCSThrusterBlock(properties, AllBlocks.BRASS_CASING::get)) | ||
| .initialProperties(() -> Blocks.IRON_BLOCK).properties(BlockBehaviour.Properties::noOcclusion) | ||
| .transform(pickaxeOnly()).tag(RocketTags.BlockTags.THRUSTERS.tag, RocketTags.BlockTags.LIGHT.tag) |
Collaborator
There was a problem hiding this comment.
I do not think we want to give the light weight tag to the encased thrusters, since these casings do not have it themselves iirc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rcs thruster: brass casing
rcs thruster: copper casing
rcs thruster: train casing
rcs thruster: Ponder updated