Skip to content

Feature: restructure RCS thruster casing and ponder added - #122

Open
Flussen wants to merge 5 commits into
CosmonauticsTeam:mainfrom
Flussen:main
Open

Flussen wants to merge 5 commits into
CosmonauticsTeam:mainfrom
Flussen:main

Conversation

@Flussen

@Flussen Flussen commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Set complete RCS block states for brass, copper, and railway casing transitions.
  • Rebuild the RCS Thruster Ponder to add casing states.
  • The RCS thruster remained unchanged in its normal state, only the possibility of adding a casing block was added.
  • When break the block or use Create wrench, it returns the used casing block and the thruster.
rcs thruster: brass casing image
rcs thruster: copper casing image
rcs thruster: train casing image
rcs thruster: Ponder updated image

@Flussen Flussen changed the title Title: fix: restructure RCS thruster Ponder casing sequence Feature: restructure RCS thruster Ponder casing sequence Aug 22, 2026
@Flussen Flussen changed the title Feature: restructure RCS thruster Ponder casing sequence Feature: restructure RCS thruster casing and ponder added Aug 22, 2026
M-W-K
M-W-K previously approved these changes Sep 2, 2026

@M-W-K M-W-K left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though question -- why are you implementing casing through a block property instead of through separate blocks and the Create interface and registry, like how Create handles encasing?

@Flussen

Flussen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

There's no specific reason, I wasn't familiar with how Create worked, but I'll definitely have to change it. I hope to fix it soon

@Flussen

Flussen commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

I've worked out this idea, however, I don't see how the train casing can be connected to other train casing blocks due to its internal system. Nevertheless, the possibility exists and it could be useful

@Flussen
Flussen requested a review from M-W-K September 4, 2026 14:49
.block("brass_encased_rcs_thruster",
properties -> new EncasedRCSThrusterBlock(properties, AllBlocks.BRASS_CASING::get))
.initialProperties(() -> Blocks.IRON_BLOCK).properties(BlockBehaviour.Properties::noOcclusion)
.transform(pickaxeOnly()).tag(RocketTags.BlockTags.THRUSTERS.tag, RocketTags.BlockTags.LIGHT.tag)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we want to give the light weight tag to the encased thrusters, since these casings do not have it themselves iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants