Alpha 1.0.0.0

Directory.Packages.props

@@ -11,8 +11,8 @@
     <PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.26100.4188" />
     <PackageVersion Include="Microsoft.Windows.SDK.BuildTools.MSIX" Version="1.7.20250829.1" />
     <PackageVersion Include="Microsoft.WindowsAppSDK" Version="1.8.260209005" />
-    <PackageVersion Include="Sentry" Version="6.4.1" />
     <PackageVersion Include="Shmuelie.WinRTServer" Version="2.2.1" />
+    <PackageVersion Include="System.Reactive" Version="6.0.1" />
     <PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
     <PackageVersion Include="System.Text.Json" Version="9.0.8" />
   </ItemGroup>

MarketExtension/Commands/MembershipCommands.cs

@@ -0,0 +1,95 @@
+using Microsoft.CommandPalette.Extensions;
+using Microsoft.CommandPalette.Extensions.Toolkit;
+using MarketExtension.Properties;
+
+namespace MarketExtension;
+
+// The watchlist/favorites membership actions. These now live solely on the per-symbol SymbolDetailPage
+// (the single place to manage membership); list rows just navigate into it. Each one just mutates
+// WatchlistStore for one instrument; the store re-publishes its observable subsets, so every live page,
+// the dock, and the detail page's own command bar re-render themselves \u2014 no manual refresh callback is
+// threaded through any more. It also pops a confirmation toast ("Added AAPL to watchlist") and keeps the
+// palette open: the silent re-render alone left users unsure the action took, and KeepOpen lets them keep
+// editing. Adapted from reference/commands/ToggleFavoriteCommand.cs.
+internal abstract partial class MembershipCommand : InvokableCommand
+{
+    // Segoe MDL2 glyphs: Add, Delete, FavoriteStar (outline), FavoriteStarFill.
+    protected const string AddGlyph = "\uE710";
+    protected const string DeleteGlyph = "\uE74D";
+    protected const string StarGlyph = "\uE734";
+    protected const string StarFillGlyph = "\uE735";
+
+    protected readonly DomainInstrument Instrument;
+
+    protected MembershipCommand(DomainInstrument instrument) => Instrument = instrument;
+
+    // Performs the mutation and returns the confirmation message to toast (so toggles can report
+    // exactly what they did).
+    protected abstract string Apply();
+
+    public override ICommandResult Invoke()
+    {
+        var message = Apply();
+        return CommandResult.ShowToast(new ToastArgs { Message = message, Result = CommandResult.KeepOpen() });
+    }
+}
+
+internal sealed partial class AddToWatchlistCommand : MembershipCommand
+{
+    public AddToWatchlistCommand(DomainInstrument instrument) : base(instrument)
+    {
+        Name = Resources.Cmd_AddToWatchlist;
+        Icon = new IconInfo(AddGlyph);
+    }
+
+    protected override string Apply()
+    {
+        WatchlistStore.Instance.AddToWatchlist(Instrument);
+        return Strings.Format(Resources.Toast_AddedToWatchlist, Instrument.Symbol);
+    }
+}
+
+internal sealed partial class RemoveFromWatchlistCommand : MembershipCommand
+{
+    public RemoveFromWatchlistCommand(DomainInstrument instrument) : base(instrument)
+    {
+        Name = Resources.Cmd_RemoveFromWatchlist;
+        Icon = new IconInfo(DeleteGlyph);
+    }
+
+    protected override string Apply()
+    {
+        WatchlistStore.Instance.RemoveFromWatchlist(Instrument.Symbol);
+        return Strings.Format(Resources.Toast_RemovedFromWatchlist, Instrument.Symbol);
+    }
+}
+
+internal sealed partial class AddToFavoritesCommand : MembershipCommand
+{
+    public AddToFavoritesCommand(DomainInstrument instrument) : base(instrument)
+    {
+        Name = Resources.Cmd_AddToFavorites;
+        Icon = new IconInfo(StarGlyph);
+    }
+
+    protected override string Apply()
+    {
+        WatchlistStore.Instance.AddToFavorites(Instrument);
+        return Strings.Format(Resources.Toast_AddedToFavorites, Instrument.Symbol);
+    }
+}
+
+internal sealed partial class RemoveFromFavoritesCommand : MembershipCommand
+{
+    public RemoveFromFavoritesCommand(DomainInstrument instrument) : base(instrument)
+    {
+        Name = Resources.Cmd_RemoveFromFavorites;
+        Icon = new IconInfo(StarFillGlyph);
+    }
+
+    protected override string Apply()
+    {
+        WatchlistStore.Instance.RemoveFromFavorites(Instrument.Symbol);
+        return Strings.Format(Resources.Toast_RemovedFromFavorites, Instrument.Symbol);
+    }
+}

MarketExtension/Commands/OpenUrlCommand.cs

@@ -0,0 +1,37 @@
+using System;
+using Microsoft.CommandPalette.Extensions;
+using Microsoft.CommandPalette.Extensions.Toolkit;
+using MarketExtension.Properties;
+
+namespace MarketExtension;
+
+// Opens a URL in the user's default browser. Used by the Elbstream attribution row (see
+// AssetIconResolver.AttributionRow). Keeps the palette open so the user returns to their list after the
+// browser launches.
+internal sealed partial class OpenUrlCommand : InvokableCommand
+{
+    private readonly string _url;
+
+    public OpenUrlCommand(string url, string name)
+    {
+        _url = url;
+        Name = name;
+    }
+
+    public override ICommandResult Invoke()
+    {
+        try
+        {
+            ProcessHelper.OpenUrl(_url);
+            return CommandResult.KeepOpen();
+        }
+        catch (Exception ex)
+        {
+            return CommandResult.ShowToast(new ToastArgs
+            {
+                Message = Strings.Format(Resources.Toast_OpenUrlFailed, _url, ex.Message),
+                Result = CommandResult.KeepOpen(),
+            });
+        }
+    }
+}

MarketExtension/Commands/PortfolioCommands.cs

@@ -0,0 +1,34 @@
+using Microsoft.CommandPalette.Extensions;
+using Microsoft.CommandPalette.Extensions.Toolkit;
+using MarketExtension.Properties;
+
+namespace MarketExtension;
+
+// Removes a holding from the portfolio. Like the watchlist/favorites membership commands, it just
+// mutates the store (PortfolioStore re-publishes its flows, so the Portfolio screen and the detail
+// page's command bar re-render themselves) and pops a confirmation toast while keeping the palette open
+// so the user knows it took and can keep editing. Adding/editing a holding is a page (SetQuantityPage),
+// not a one-shot command, because it needs a quantity input.
+internal sealed partial class RemoveFromPortfolioCommand : InvokableCommand
+{
+    private const string DeleteGlyph = "\uE74D"; // Segoe MDL2 Delete
+
+    private readonly DomainInstrument _instrument;
+
+    public RemoveFromPortfolioCommand(DomainInstrument instrument)
+    {
+        _instrument = instrument;
+        Name = Resources.Cmd_RemoveFromPortfolio;
+        Icon = new IconInfo(DeleteGlyph);
+    }
+
+    public override ICommandResult Invoke()
+    {
+        PortfolioStore.Instance.Remove(_instrument.Symbol);
+        return CommandResult.ShowToast(new ToastArgs
+        {
+            Message = Strings.Format(Resources.Toast_RemovedFromPortfolio, _instrument.Symbol),
+            Result = CommandResult.KeepOpen(),
+        });
+    }
+}

MarketExtension/Data/Finnhub/ApiFinnhubCandleDto.cs

@@ -0,0 +1,21 @@
+using System.Collections.Generic;
+using System.Text.Json.Serialization;
+
+namespace MarketExtension;
+
+// Api layer: the raw shape of Finnhub's GET /stock/candle (and /crypto/candle — identical shape)
+// response. Internal to the Finnhub provider, which maps it into a DomainCandleSeries. The arrays are
+// column-oriented and parallel by index: Close[i]/Timestamps[i] are candle i's close and time. Status
+// is "ok" or "no_data". Open/High/Low/Volume are parsed but currently unused (kept for a future OHLC
+// tooltip). Premium endpoint — a free-tier key gets a 403 (handled in the provider).
+//
+// Registered on FinnhubJsonContext via the SINGLE [JsonSerializable] declaration in
+// ApiFinnhubQuoteDto.cs — never a second partial declaration (see the source-gen gotcha in CLAUDE.md).
+internal sealed record ApiFinnhubCandleDto(
+    [property: JsonPropertyName("c")] IReadOnlyList<decimal>? Close,
+    [property: JsonPropertyName("h")] IReadOnlyList<decimal>? High,
+    [property: JsonPropertyName("l")] IReadOnlyList<decimal>? Low,
+    [property: JsonPropertyName("o")] IReadOnlyList<decimal>? Open,
+    [property: JsonPropertyName("t")] IReadOnlyList<long>? Timestamps,
+    [property: JsonPropertyName("v")] IReadOnlyList<decimal>? Volume,
+    [property: JsonPropertyName("s")] string? Status);

MarketExtension/Data/Finnhub/ApiFinnhubProfileDto.cs

@@ -0,0 +1,14 @@
+using System.Text.Json.Serialization;
+
+namespace MarketExtension;
+
+// Api layer: the slice of Finnhub's GET /stock/profile2?symbol= response we care about — the instrument's
+// reporting `currency`. Finnhub's /quote (c/d/dp/pc) carries NO currency, so the provider resolves it
+// here, ONCE per symbol (currency is static metadata), and caches it forever. US tickers come back "USD";
+// a paid plan's non-US listings report their local currency (e.g. "GBp" for London → normalized to GBP).
+//
+// Registered on FinnhubJsonContext in ApiFinnhubQuoteDto.cs (the single context declaration) per the
+// CLAUDE.md source-gen gotcha — NOT in its own context here.
+internal sealed record ApiFinnhubProfileDto(
+    [property: JsonPropertyName("currency")] string? Currency,
+    [property: JsonPropertyName("ticker")]   string? Ticker);

MarketExtension/Data/Finnhub/ApiFinnhubQuoteDto.cs

@@ -0,0 +1,21 @@
+using System.Text.Json.Serialization;
+
+namespace MarketExtension;
+
+// Api layer: the raw shape of Finnhub's GET /quote response. Internal to the Finnhub provider,
+// which maps it into a DomainQuote. Fields are nullable because Finnhub returns null for
+// change/percent on instruments without a previous close; the provider coalesces to 0.
+//
+// Source-generated (de)serialization keeps the AOT/trim build clean: reflection-based JSON would
+// trip ILLinkTreatWarningsAsErrors.
+internal sealed record ApiFinnhubQuoteDto(
+    [property: JsonPropertyName("c")]  decimal? Current,        // current price
+    [property: JsonPropertyName("d")]  decimal? Change,         // absolute change
+    [property: JsonPropertyName("dp")] decimal? ChangePercent,  // percent change
+    [property: JsonPropertyName("pc")] decimal? PreviousClose); // previous close
+
+[JsonSerializable(typeof(ApiFinnhubQuoteDto))]
+[JsonSerializable(typeof(ApiFinnhubSearchDto))]  // /search response — see ApiFinnhubSearchDto.cs
+[JsonSerializable(typeof(ApiFinnhubCandleDto))]  // /stock/candle + /crypto/candle — see ApiFinnhubCandleDto.cs
+[JsonSerializable(typeof(ApiFinnhubProfileDto))] // /stock/profile2 (native currency) — see ApiFinnhubProfileDto.cs
+internal sealed partial class FinnhubJsonContext : JsonSerializerContext;

MarketExtension/Data/Finnhub/ApiFinnhubSearchDto.cs

@@ -0,0 +1,24 @@
+using System.Collections.Generic;
+using System.Text.Json.Serialization;
+
+namespace MarketExtension;
+
+// Api layer: the raw shape of Finnhub's GET /search (symbol lookup) response. Internal to the
+// Finnhub provider, which maps each result into a provider-agnostic DomainInstrument. All fields
+// are nullable because Finnhub omits them for sparse matches; the provider skips results without a
+// symbol.
+//
+// Source-generated (de)serialization keeps the AOT/trim build clean — reflection-based JSON would
+// trip ILLinkTreatWarningsAsErrors. Registration lives on the single FinnhubJsonContext
+// declaration in ApiFinnhubQuoteDto.cs: the JSON source generator does NOT support [JsonSerializable]
+// attributes split across multiple partial declarations (it emits colliding hintNames and fails),
+// so all serializable types for that context must be attributed in one place.
+internal sealed record ApiFinnhubSearchDto(
+    [property: JsonPropertyName("count")]  int Count,
+    [property: JsonPropertyName("result")] IReadOnlyList<ApiFinnhubSearchResultDto>? Result);
+
+internal sealed record ApiFinnhubSearchResultDto(
+    [property: JsonPropertyName("description")]   string? Description,   // e.g. "APPLE INC"
+    [property: JsonPropertyName("displaySymbol")] string? DisplaySymbol, // UI symbol, e.g. "AAPL"
+    [property: JsonPropertyName("symbol")]        string? Symbol,        // canonical id for /quote
+    [property: JsonPropertyName("type")]          string? Type);         // e.g. "Common Stock"