Fix fuel save bypass in MotorController#1197
Open
cjkreklow wants to merge 2 commits intoCourseplay:mainfrom
Open
Fix fuel save bypass in MotorController#1197cjkreklow wants to merge 2 commits intoCourseplay:mainfrom
cjkreklow wants to merge 2 commits intoCourseplay:mainfrom
Conversation
MotorController:update() was returning prematurely when Fuel Save was disabled, bypassing all additional MotorController logic
pvaiko
requested changes
Feb 23, 2026
| self.timerSet = false | ||
| return | ||
| end | ||
| if self:isFuelSaveDisabled() or self.driveStrategy:getMaxSpeed() > |
Contributor
There was a problem hiding this comment.
I'd be more comfortable with this if we changed this to an elseif to prevent the rest of motor starting logic to run.
Author
There was a problem hiding this comment.
Since this makes the first two blocks functionally identical, I pushed a slightly different change that just condenses the two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MotorController:update() was returning prematurely when Fuel Save was disabled, bypassing all additional MotorController logic.
Proposed fix for #1195