Skip to content

fix(di): move workouts overview cubit outside di #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CowboyGH merged 1 commit into from
Apr 4, 2026
Merged

fix(di): move workouts overview cubit outside di #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/core/di/di.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ import '../../features/profile/domain/repositories/profile_parameters_repository
import '../../features/profile/domain/repositories/profile_repository.dart';
import '../../features/profile/domain/repositories/profile_statistics_repository.dart';
import '../../features/profile/presentation/cubits/profile_refresh_cubit.dart';
import '../../features/subscriptions/data/remote/subscriptions_api_client.dart';
import '../../features/subscriptions/data/remote/subscription_payment_api_client.dart';
import '../../features/subscriptions/data/remote/subscriptions_api_client.dart';
import '../../features/subscriptions/data/repositories/subscriptions_repository_impl.dart';
import '../../features/subscriptions/domain/repositories/subscriptions_repository.dart';
import '../../features/tests/attempt/data/repositories/authenticated_test_attempt_repository_impl.dart';
Expand All @@ -47,7 +47,6 @@ import '../../features/workouts/execution/data/repositories/workout_execution_re
import '../../features/workouts/execution/domain/repositories/workout_execution_repository.dart';
import '../../features/workouts/overview/data/repositories/workouts_overview_repository_impl.dart';
import '../../features/workouts/overview/domain/repositories/workouts_overview_repository.dart';
import '../../features/workouts/overview/presentation/cubits/workouts_overview_cubit.dart';
import '../network/api_paths.dart';
import '../network/dio_setup.dart';
import '../services/fitness_start_progress_storage/fitness_start_progress_storage.dart';
Expand Down Expand Up @@ -226,10 +225,6 @@ Future<void> setupDI() async {
di<WorkoutsApiClient>(),
),
);
di.registerLazySingleton<WorkoutsOverviewCubit>(
() => WorkoutsOverviewCubit(di<WorkoutsOverviewRepository>()),
dispose: (cubit) => cubit.close(),
);
di.registerLazySingleton<WorkoutDetailsRepository>(
() => WorkoutDetailsRepositoryImpl(
di<AppLogger>(),
Expand Down
7 changes: 6 additions & 1 deletion lib/features/profile/presentation/pages/profile_page_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,16 @@ import '../../../cards/presentation/cubits/save_card_cubit.dart';
import '../../../cards/presentation/cubits/set_default_card_cubit.dart';
import '../../../subscriptions/domain/repositories/subscriptions_repository.dart';
import '../../../subscriptions/presentation/cubits/cancel_subscription_cubit.dart';
import '../../../workouts/overview/domain/repositories/workouts_overview_repository.dart';
import '../../../workouts/overview/presentation/cubits/workouts_overview_cubit.dart';
import '../../domain/repositories/profile_parameters_repository.dart';
import '../../domain/repositories/profile_repository.dart';
import '../../domain/repositories/profile_statistics_repository.dart';
import '../cubits/delete_profile_cubit.dart';
import '../cubits/profile_parameters_cubit.dart';
import '../cubits/profile_refresh_cubit.dart';
import '../cubits/profile_subscription_cubit.dart';
import '../cubits/profile_statistics_cubit.dart';
import '../cubits/profile_subscription_cubit.dart';
import '../cubits/profile_user_cubit.dart';
import 'profile_page.dart';

Expand Down Expand Up @@ -86,6 +88,9 @@ class ProfilePageBuilder extends StatelessWidget {
BlocProvider(
create: (_) => CancelSubscriptionCubit(di<SubscriptionsRepository>()),
),
BlocProvider(
create: (_) => WorkoutsOverviewCubit(di<WorkoutsOverviewRepository>()),
),
],
child: const ProfilePage(),
);
Expand Down
3 changes: 1 addition & 2 deletions lib/features/profile/presentation/widgets/profile_parameters_section_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:flutter/services.dart';
import 'package:flutter_bloc/flutter_bloc.dart';

import '../../../../../core/constants/app_strings.dart';
import '../../../../../core/di/di.dart';
import '../../../../../uikit/buttons/button_size.dart';
import '../../../../../uikit/buttons/button_state.dart';
import '../../../../../uikit/buttons/main_button.dart';
Expand Down Expand Up @@ -233,7 +232,7 @@ class _ProfileParametersSectionWidgetState extends State<ProfileParametersSectio
if (!state.isSubmitting) {
_closeDropdown();
if (state.shouldReloadWorkouts) {
unawaited(di<WorkoutsOverviewCubit>().loadWorkouts());
unawaited(context.read<WorkoutsOverviewCubit>().loadWorkouts());
context.read<ProfileParametersCubit>().consumeWorkoutsReloadRequest();
}
unawaited(context.read<ProfileStatisticsCubit>().reloadCurrentPhaseSummary());
Expand Down
7 changes: 5 additions & 2 deletions lib/features/workouts/overview/presentation/pages/workouts_overview_page_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import 'package:flutter/widgets.dart';
import 'package:flutter_bloc/flutter_bloc.dart';

import '../../../../../core/di/di.dart';
import '../../domain/repositories/workouts_overview_repository.dart';
import '../cubits/workouts_overview_cubit.dart';
import 'workouts_overview_page.dart';

Expand All @@ -12,8 +13,10 @@ class WorkoutsOverviewPageBuilder extends StatelessWidget {

@override
Widget build(BuildContext context) {
return BlocProvider.value(
value: di<WorkoutsOverviewCubit>()..loadWorkouts(),
return BlocProvider(
create: (context) => WorkoutsOverviewCubit(
di<WorkoutsOverviewRepository>(),
)..loadWorkouts(),
child: const WorkoutsOverviewPage(),
);
}
Expand Down
Loading