Skip to content

fix(subscriptions): force uppercase on payment card holder input - #74

Merged
CowboyGH merged 1 commit into
developfrom
fix/sub-payment-cardholder-uppercase
Jun 13, 2026
Merged

CowboyGH merged 1 commit into
developfrom
fix/sub-payment-cardholder-uppercase

Conversation

@CowboyGH

Copy link
Copy Markdown
Owner

Why

The "add card" dialog in Profile auto-uppercases the cardholder name as you type and stores/displays the normalized value. The subscription payment dialog had no such formatter — lowercase input was accepted on screen but fails the ^[A-Z ]+$ validator on submit, and the preview/payload sent raw (unnormalized) text. Two dialogs with the same field behaved differently.

What

  • Added _CardHolderTextInputFormatter to subscription_payment_dialog.dart (same formatter as in save_card_dialog.dart) — forces uppercase as the user types.
  • Added _normalizedCardHolder getter (trim().toUpperCase()), used for the payment payload and the card preview.

How to test

  1. Profile → Subscriptions catalog → open payment dialog → type a cardholder name in lowercase.
  2. Confirm it displays in uppercase as you type (both in the field and in the card preview), matching the "add card" dialog in Profile.
  3. Submit with a valid card — payment proceeds without a cardholder validation error.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@CowboyGH, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 48 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bdb9797-7ece-404c-ad1d-d150a7b94590

📥 Commits

Reviewing files that changed from the base of the PR and between 482c755 and b8639ba.

📒 Files selected for processing (1)
  • lib/features/subscriptions/presentation/widgets/subscription_payment_dialog.dart
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sub-payment-cardholder-uppercase

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CowboyGH CowboyGH self-assigned this Jun 13, 2026
@CowboyGH CowboyGH added area: ui/ux Widgets, layout, animations, or design type: bug Something isn't working labels Jun 13, 2026
@CowboyGH
CowboyGH merged commit af0eb43 into develop Jun 13, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Widgets, layout, animations, or design type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant