Fix OSR config and APPEND_STATUS mask - #2
Open
w4iei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bitfield issues in the register definitions/config path:
• TLA25x8_Configure() was building OSR_CFG using OSC_SEL shift/mask; now uses TLA25x8_OSR_SHIFT/MASK so oversampling is configured correctly.
• TLA25x8_APPEND_STATUS_MASK incorrectly used TLA25x8_CAL_SHIFT; now uses TLA25x8_APPEND_STATUS_SHIFT so the mask targets the correct bit.