feat: persist and serve attestations via repository and cache layer#368
Merged
Baskarayelu merged 1 commit intoMay 29, 2026
Merged
Conversation
|
@Vivian-04 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #321 [Backend] Wire attestations endpoint to repository and remove empty-array placeholder in app.ts
Summary
Wires the public attestation API to the real repository/cache/outbox path instead of the placeholder handlers in
src/app.ts.Changes
src/routes/attestations.tsfromsrc/app.ts.attestation.createdoutbox event.409.keyandvalue.docs/api.mdanddocs/openapi.yaml.Verification
Passing focused verification:
Result:
4 passed,46 tests passed.Repo-wide verification still has unrelated existing failures:
npm.cmd run testfails in env config, member mocks, API key/webhook audit logs, bulk verification, rate limit, and Horizon listener tests.npm.cmd run buildfails on unrelated TypeScript errors across Soroban retry types, config timeout fields, outbox metrics, webhook repository interface, audit/service types, key manager types, and other existing modules.The attestation-related webhook event typing issue was fixed by adding
attestation.createdandattestation.revokedtoWebhookEventType.Closes #321