test(ingestion): add fixture-based end-to-end coverage for fetch runtime and persistence - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds fixture-based end-to-end ingestion coverage for the
v0.3.0runtime and persistence path.The repository already had source-specific integration coverage for GitHub, news RSS, changelog, runtime dispatch, and CLI non-zero behavior. This PR adds the missing cross-source runtime-level tests that exercise real fetchers against mocked upstream responses and verify persisted rows in the same temporary SQLite database.
Linked issue(s)
Milestone fit
This PR strengthens the
v0.3.0ingestion milestone by adding deterministic end-to-end coverage for the live runtime path without introducing any new product behavior.It stays inside milestone scope by:
fetch_runs,metric_snapshots, andcontent_itemsWhat changed
internal/fetch/runtime_e2e_test.gofetch_runs,metric_snapshots, andcontent_itemsfetch_runshttptesthelpers and fixture pack patterns already present ininternal/fetchWhy this shape
Most of the issue scope was already covered in
mainthrough:Given that local repository state, this PR keeps the change minimal and auditable by adding the missing multi-source E2E runtime coverage instead of refactoring the existing test suite.
Out of scope
Validation
go test ./internal/fetch -count=1go test ./... -count=1go vet ./...python3 ./scripts/trim-whitespace.py --checkmake ciDocumentation impact
Reviewer focus
internal/fetch/runtime_e2e_test.goAuditability checklist
Notes for merge
Preferred merge method: