feat(schedule): add deterministic one-shot scheduler execution - #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a deterministic one-shot scheduler flow that selects due schedule jobs from configured cadences, executes work through the existing fetch runtime, and persists execution outcomes in
schedule_runs.Linked issue(s)
Milestone fit
This PR delivers the v0.4.0 one-shot scheduler slice on top of the existing processing storage contracts. It keeps scheduler behavior deterministic, config-driven, and reviewable while explicitly deferring daemon/process-supervision/API concerns.
What changed
internal/scheduleruntime for due/not-due selection, persistedschedule_runs, and mixed success/failure handlingsource_idfilter so scheduler execution can reuse the existing ingestion path instead of introducing a parallel fetch pathsignalscope schedule --config <dir> --db <path> [--job <schedule-job-id>]Out of scope
Validation
Mark what you actually ran:
python3 ./scripts/trim-whitespace.py --checkgo vet ./...go test ./...make ciDocumentation impact
README.mdSPEC.mddocs/AGENTS.md,CONTRIBUTING.md)CHANGELOG.mdReviewer focus
Call out the highest-risk files, behaviors, or assumptions to review.
internal/schedule/runtime.gointernal/fetch/runtime.gointernal/cli/app.goschedule_runs.started_at + cadenceAuditability checklist
Notes for merge
Preferred merge method: