Persist repeated news co-mention candidate suggestions - #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
news.co_mentionmentionsfirst_seen_atwhile updatingmention_countandlast_seen_atDetails
This implements the candidate suggestion path for alert rules using:
event_key: news.co_mentioncondition.type: candidate_repeat_gteThe candidate extractor is intentionally conservative:
When the same candidate is seen again, the stored suggestion is updated in place:
mention_countkeeps the highest observed countfirst_seen_atkeeps the earliest observed timestamplast_seen_atkeeps the latest observed timestampTesting
go test ./internal/alerts ./internal/storagego test ./...make ciDeferred
news.co_mentioncandidate_suggestionsCloses #49