Skip to content

FIX: premature browser validation notice https://github.com/Crocoblock/issues-tracker/issues/18733 #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ObitoTM merged 2 commits into from
Jul 29, 2026
Merged

FIX: premature browser validation notice https://github.com/Crocoblock/issues-tracker/issues/18733 #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72c450
FIX: premature browser validation notice https://github.com/Crocobloc…
ObitoTM Jul 16, 2026
6b89ff8
Merge branch 'release/3.6.5' into issue/18733
ObitoTM Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/build/frontend/main.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('wp-i18n'), 'version' => 'b145b8f23bfb859fdb34');
<?php return array('dependencies' => array('wp-i18n'), 'version' => '153ab9d38663373cb700');
2 changes: 1 addition & 1 deletion assets/build/frontend/main.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion assets/src/frontend/main/reporting/BrowserReporting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ function BrowserReporting() {
// browser automatically hide tooltip messages
};
this.validateOnChange = function () {
this.validate().then( () => {} ).catch( () => {} );
this.getErrors().then( errors => {
this.validityState.current = !Boolean( errors.length );

if ( !errors.length ) {
this.clearReport();
}
} ).catch( () => {} );
};

this.getErrorsRaw = async function ( promises ) {
Expand Down
Loading