Skip to content

Upgrade ember-modifier to be compatible with modern Glint - #290

Closed
johanrd wants to merge 1 commit into
CrowdStrike:mainfrom
johanrd:main
Closed

johanrd wants to merge 1 commit into
CrowdStrike:mainfrom
johanrd:main

Conversation

@johanrd

@johanrd johanrd commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-bot Bot commented Apr 11, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6697b90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NullVoxPopuli

Copy link
Copy Markdown
Contributor

I forked thin library and kept the same behavior and apis, if you are curious about migrating to something a little more maintained

https://ue-table.pages.dev/

@johanrd

johanrd commented Apr 11, 2025 •

Copy link
Copy Markdown
Contributor Author

@NullVoxPopuli yes, I'm eager to try! last time I stopped at unpublished npm package, (which I now see that is now resolved), and at the need of patching Reordering hidden columns. I'll try again, thanks!

Also, see universal-ember/table#68, which I found interesting.

@NullVoxPopuli

Copy link
Copy Markdown
Contributor

Would you be willing to apply your patch in a pr? <3

@johanrd

johanrd commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

@NullVoxPopuli ok, I ported the PR here: universal-ember/table#74. There may still be some unanswered questions from the original PR (and three skipped tests), but I've used it with success in practice at least.

@johanrd johanrd closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants