Repository navigation
fix: preserve selected page template content - #79
Merged
Merged
Conversation
Resolve the selected template when the New Page action creates the record instead of setting undeclared form state. Add action-level regression coverage and document the v1.7.0 fix.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 4
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New pages created from a built-in or saved custom template currently lose all template content and open empty. Resolve the final template selection inside the create handler and remove the reactive callback that writes to an undeclared
contentfield. Blank pages and cleared selections still create empty content.Adds nine regression cases through the real Filament/Livewire New Page action, updates the template guide, and prepares the v1.7.0 changelog. Before the fix, six cases failed with empty saved content; all nine pass after the fix.
Validation:
CACHE_STORE=array vendor/bin/pest: 1,239 tests passed, 3,930 assertions.bin/docs-lint: 43 pages passed.git diff --checkpassed.The existing lockfile audit reports dependency advisories, including a high-severity CommonMark advisory; this PR changes no dependencies. The lockfile is excluded from Composer distribution archives.
Refs #78. Release target: v1.7.0 (requested minor release).
Summary by CodeRabbit