Repository navigation
Refactor: unified MILP bounded trail search - #533
Merged
Merged
Conversation
…ch' into refactor/milp_bounded_trail_search
p-huynh
changed the title
peacker
requested changes
Sep 22, 2026
peacker
left a comment
peacker
left a comment
Collaborator
There was a problem hiding this comment.
Do not skip doctests and make sure they are different from the pytests.
Address also sonar warnings.
# Conflicts: # claasp/cipher_modules/models/milp/milp_models/milp_xor_differential_model.py # claasp/cipher_modules/models/milp/milp_models/milp_xor_linear_model.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the MILP
find_onetrail search method to support optional lower and upper weight bounds directly:lower_boundandupper_boundparameters to MILP XOR differential and XOR linearfind_onemethods.weight_range_constraintsto support one-sided bounds and no bounds.find_one_*_with_fixed_weightandfind_one_*_with_weight_at_mostmethods.