Skip to content

had ordering wrong in quadratic edge method. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmhamel merged 1 commit into from
Apr 28, 2026
Merged

had ordering wrong in quadratic edge method. #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/elements/Edge.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ end
function shape_function_value(::Edge{Lagrange, 2, false}, _, ξ::Number)
return [
0.5 * ξ * (ξ - 1.0),
1.0 - ξ^2,
0.5 * ξ * (ξ + 1.0),
1.0 - ξ^2
]
end

Expand All @@ -260,20 +260,20 @@ function shape_function_value(::Edge{Lagrange, 2, true}, _, ξ::Number)
end

function shape_function_gradient(::Edge{Lagrange, 2, false}, _, ξ::Number)
return SVector(
return [
0.5 * (2.0 * ξ - 1.0),
-2.0 * ξ,
0.5 * (2.0 * ξ + 1.0),
)
-2.0 * ξ
]
end

# Second order shifted
function shape_function_gradient(::Edge{Lagrange, 2, true}, _, ξ::Number)
return SVector(
return [
4.0 * ξ - 3.0,
4.0 - 8.0 * ξ,
4.0 * ξ - 1.0,
)
]
end

function shape_function_value(e::Edge{Lagrange, PD, Shifted}, Xs, ξ::Number) where {PD, Shifted}
Expand Down
Loading