Skip to content

fix ci#1

Merged
quentinformatique merged 3 commits intomainfrom
feat/fix-CI
May 19, 2025
Merged

fix ci#1
quentinformatique merged 3 commits intomainfrom
feat/fix-CI

Conversation

@quentinformatique
Copy link
Member

This pull request includes updates to the file paths in the codebase for better organization and removes redundant steps in the CI workflow. The most important changes include modifying file paths in scripts to reflect the new directory structure and simplifying the CI workflow by removing the test coverage step.

File path updates:

  • Updated the dataset file path in app/model/train_color_model.py to use a relative path consistent with the new directory structure (./data/dataset.csv).
  • Adjusted the directory creation path in app/model/train_color_model.py to ensure the model is saved in the correct location (./).

CI workflow simplification:

  • Updated the script paths in .github/workflows/ci.yml to match the new directory structure (data/generate_synthetic_dataset.py and app/model/train_color_model.py).
  • Removed the test coverage step from the CI workflow to streamline the process.

@quentinformatique quentinformatique requested a review from Copilot May 19, 2025 09:35
@quentinformatique quentinformatique self-assigned this May 19, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes file paths for consistency and streamlines the CI workflow by removing redundant steps.

  • Adjust dataset loading and model saving paths in the training script
  • Update CI workflow script paths and remove the test coverage step

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
app/model/train_color_model.py Update dataset path, simplify directory creation, and adjust save logic
.github/workflows/ci.yml Point to new script locations and drop the coverage-report step
Comments suppressed due to low confidence (2)

app/model/train_color_model.py:22

  • The model is saved to the project root (color_model.pkl), but the print message indicates app/model/color_model.pkl. Either update the dump path to app/model/color_model.pkl or adjust the print statement to reflect where the file is actually saved.
joblib.dump(model, 'color_model.pkl')

app/model/train_color_model.py:21

  • Calling os.makedirs('./', exist_ok=True) is redundant since the current directory always exists. Consider removing this line or specifying the intended target directory (e.g., app/model).
os.makedirs('./', exist_ok=True)

@quentinformatique quentinformatique merged commit 6014a55 into main May 19, 2025
2 checks passed
@quentinformatique quentinformatique deleted the feat/fix-CI branch May 19, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants