Skip to content

fix: uncomplicate type definitions#11

Merged
twnlink merged 1 commit into
Cumcord:masterfrom
marshift:uncomplicate-typedefs
Aug 2, 2025
Merged

fix: uncomplicate type definitions#11
twnlink merged 1 commit into
Cumcord:masterfrom
marshift:uncomplicate-typedefs

Conversation

@marshift
Copy link
Copy Markdown
Contributor

@marshift marshift commented Jul 7, 2025

the type definitions used in spitroast have been a touchy subject for a long time. the adjustments made by this pull request should hopefully end that. they are considerably less complex, but still robust and well-tested - i've been using them in my fork, strawberry, for a while now.

this DOES induce a file size regression, but fixes an actual runtime regression:

${String(funcName)} is not a function in ${funcParent.constructor.name}

i am now explicitly casting funcName to String, which is needed as it can be symbol which errors if implicitly cast at runtime.

@twnlink twnlink merged commit 79a71fa into Cumcord:master Aug 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants