fix(authz): derive visited_by from observed values to eliminate Firefox false positives - #118
Open
lorenzozanee wants to merge 1 commit into
Open
Conversation
…ox false positives Firefox-captured traffic lacks capture-time page_visited_by, so the authz tester infers admin-only from path alone and reports false positives when both low/high roles legitimately reach the same endpoint via UI. The per-credential reachability is already stored in request_observation for both capture paths. Derive visited_by from distinct observed credential labels (merged with any capture-time label) and surface it in the Access Context for both the ingest prompt builder and subagent dispatch, and in web_get_request_detail. Fixes CyberStrikeus#99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #99 — Firefox-captured traffic never populates capture-time
page_visited_by, so the authz tester lacks the visited-by signal and infers admin-only from the path, reporting false positives when both roles legitimately reach the same endpoint via UI. Derivevisited_byfromrequest_observation(distinct observed credential labels merged with any capture-time label) and surface it in the Access Context.Type of change
Security impact
How did you verify it works?
Typecheck clean and existing session tests pass; verified Access Context now emits
Visited by:for Firefox traffic withoutpageUrl.Checklist
bun turbo typecheckpasses