Repository navigation
Fix serialization of enums with Null values - #453
Open
andreas-hilti wants to merge 1 commit into
Open
andreas-hilti wants to merge 1 commit into
andreas-hilti wants to merge 1 commit into
Conversation
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Contributor
Author
|
There are a couple of enums that I haven't touched:
There are also a couple of instances where the enums are required, e.g. DataClassification.Flow; there I prevent writing the "Null" value, but this doesn't guarantee a valid JSON, given that a proper enum value is required. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #445
The
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)]prevents writing the Null value in the Json case, while theShouldSerialize...member prevents it in the Xml case.