Repository navigation
Conversation
chaitika
marked this pull request as draft
October 9, 2026 12:02
Every 4xx was treated as a definitive rejection, including 429 from the indexer's rate limit, so a scan failed on the first throttled range. 429 now goes through the existing backoff instead of failing at once.
A restored wallet, or a second device on the same seed, kept counting SP coins spent elsewhere. Each scan now also fetches the indexer's spent index and matches our outpoints against it on the device. Our own sends get confirmed; other spends are recorded as one "Unknown" transaction per block. Existing wallets get a one-off catch-up. Blocks the indexer has no spent index for stay unchecked until it does, and receiving works as before.
The Electrum check sent the address of every unspent silent payment coin to the Electrum server after each scan, which links them to each other and to the wallet's regular addresses. The spent index finds the same spends by matching outpoints on the device. Running both also broke the history: a coin the Electrum check marked spent first was skipped by the spent index, so its spend was never recorded.
chaitika
force-pushed
the
feat/external-spend-detection-continued
branch
from
November 12, 2026 14:16
93c6c9e to
ed860c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #170. A restored wallet, or a second device on the same seed, now detects SP coins spent elsewhere by matching its own outpoints against the indexer's spent index locally (#156).
Needs the indexer's spent index (CypherCommons/shroud-indexer#118), deployed with a reindex. Without it, receiving works as before and spends aren't detected.
On top of #170:
Not in this PR: undoing spent marks after a reorg.