Skip to content

fix(ci): disable IPO for test coverage builds - #1163

Draft
IvanaGyro wants to merge 1 commit into
masterfrom
codex/disable-ipo-for-tests
Draft

fix(ci): disable IPO for test coverage builds#1163
IvanaGyro wants to merge 1 commit into
masterfrom
codex/disable-ipo-for-tests

Conversation

@IvanaGyro

Copy link
Copy Markdown
Member

Summary

  • Disable CMAKE_INTERPROCEDURAL_OPTIMIZATION when RUN_TESTS=ON.
  • Preserve the existing IPO behavior for non-test builds.

Why

LTO can cause the pybind/ translation units to disappear from Codecov coverage attribution. Disabling IPO for coverage builds keeps source-level coverage data associated with the original files.

Validation

No local tests were run per request; CI should verify the change.

Fixes #1162

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Co-Authored-By: Codex <noreply@openai.com>
@IvanaGyro
IvanaGyro force-pushed the codex/disable-ipo-for-tests branch from 98d9dae to 4f51673 Compare August 2, 2026 08:11
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.47%. Comparing base (a969a66) to head (4f51673).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   67.92%   71.47%   +3.55%     
==========================================
  Files         208      208              
  Lines       22355    22355              
  Branches       72       72              
==========================================
+ Hits        15185    15979     +794     
+ Misses       7148     6354     -794     
  Partials       22       22              
Flag Coverage Δ
cpp 71.60% <ø> (+3.61%) ⬆️
python 63.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
C++ backend 71.60% <ø> (+3.61%) ⬆️
Python bindings ∅ <ø> (∅)
Python package 63.96% <ø> (ø)
see 11 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a969a66...4f51673. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codecov/project red on every PR since 2026-07-30: pybind/ files dropped out of the C++ coverage report

1 participant