build(tests): make codecov coverage opt-in - #1131
Merged
Merged
Conversation
The codecov/FindGcov/FindLcov modules are fetched at configure time from a third-party server via CMakeCM. That breaks offline builds and adds an unnecessary supply-chain dependency for regular test runs. Coverage is now gated behind ENABLE_COVERAGE=ON. Default builds compile and run the Catch2 suite fully offline (verified: 53/53 pass).
AnotherFoxGuy
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
codecov/FindGcov/FindLcovCMake modules are fetched at configure time from a third-party server via CMakeCM. That breaks offline builds and adds a supply-chain dependency that regular test runs don't need.Change
Gate the coverage tooling behind a new
ENABLE_COVERAGEoption (defaultOFF):and likewise for
add_coverage()/coverage_evaluate(). CI setups that need coverage can simply pass-DENABLE_COVERAGE=ON.Testing
Default build (Coverage OFF) compiles and runs the Catch2 suite fully offline: 53/53 tests pass (Arch Linux, GCC 16.2, CMake 4.4, network-less configure verified).