🛡️ Sentinel: [MEDIUM] Fix Rich Text Injection in QTextEdit - #220
🛡️ Sentinel: [MEDIUM] Fix Rich Text Injection in QTextEdit#220dieterolson wants to merge 2 commits into
Conversation
Added `setAcceptRichText(False)` to `QTextEdit` widgets across the application (chat panel, setup logs, hub dialog logs, and settings prompt). By default, `QTextEdit` accepts HTML (via drag/drop or copy/paste), which could be leveraged to inject unexpected rich text UI elements or load external images if not strictly handling plain text. Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Added `setAcceptRichText(False)` to `QTextEdit` widgets across the application (chat panel, setup logs, hub dialog logs, and settings prompt). By default, `QTextEdit` accepts HTML (via drag/drop or copy/paste), which could be leveraged to inject unexpected rich text UI elements or load external images if not strictly handling plain text. Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
|
Closing in favor of consolidated batch PR #227. |
🚨 Severity: MEDIUM
💡 Vulnerability:
QTextEditwidgets accept rich text (HTML) by default, allowing users to paste or drop HTML content which might inject unexpected UI styling or remote content.🎯 Impact: UI redressing or potential remote resource loading via HTML injection in text input boxes.
🔧 Fix: Explicitly called
setAcceptRichText(False)on allQTextEditinstances handling logs, chat displays, or user prompts.✅ Verification: Ran unit tests and verified all tests pass, ensuring no unintended side effects.
PR created automatically by Jules for task 1334727260357521790 started by @dieterolson