Skip to content

🛡️ Sentinel: [MEDIUM] Fix Rich Text Injection in QTextEdit - #220

Closed
dieterolson wants to merge 2 commits into
mainfrom
sentinel-fix-qtextedit-rich-text-1334727260357521790
Closed

🛡️ Sentinel: [MEDIUM] Fix Rich Text Injection in QTextEdit#220
dieterolson wants to merge 2 commits into
mainfrom
sentinel-fix-qtextedit-rich-text-1334727260357521790

Conversation

@dieterolson

Copy link
Copy Markdown
Contributor

🚨 Severity: MEDIUM
💡 Vulnerability: QTextEdit widgets accept rich text (HTML) by default, allowing users to paste or drop HTML content which might inject unexpected UI styling or remote content.
🎯 Impact: UI redressing or potential remote resource loading via HTML injection in text input boxes.
🔧 Fix: Explicitly called setAcceptRichText(False) on all QTextEdit instances handling logs, chat displays, or user prompts.
✅ Verification: Ran unit tests and verified all tests pass, ensuring no unintended side effects.


PR created automatically by Jules for task 1334727260357521790 started by @dieterolson

Added `setAcceptRichText(False)` to `QTextEdit` widgets across the application (chat panel, setup logs, hub dialog logs, and settings prompt). By default, `QTextEdit` accepts HTML (via drag/drop or copy/paste), which could be leveraged to inject unexpected rich text UI elements or load external images if not strictly handling plain text.

Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

⚠️ SPEC.md Update Required

Source files were modified in this PR but SPEC.md was not updated.

Per the Specification-Driven Development Policy:

  • Any PR that adds, removes, or changes functionality must update SPEC.md
  • Update the relevant sections (features, architecture, tests, dependencies, etc.)
  • Bump the Spec Version if making substantive changes

To resolve:

  1. Update SPEC.md to reflect your changes, OR
  2. Add the spec-exempt label if this PR genuinely doesn't affect the spec (e.g., pure refactor with no behavior change)

This check is enforced by the spec-check CI workflow.

Added `setAcceptRichText(False)` to `QTextEdit` widgets across the application (chat panel, setup logs, hub dialog logs, and settings prompt). By default, `QTextEdit` accepts HTML (via drag/drop or copy/paste), which could be leveraged to inject unexpected rich text UI elements or load external images if not strictly handling plain text.

Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
@dieterolson

Copy link
Copy Markdown
Contributor Author

Closing in favor of consolidated batch PR #227.

auto-merge was automatically disabled August 11, 2026 05:58

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant