Skip to content

feat(rate-of-closure): add canonical camera preset parity - #4358

Closed
d-sorgcodexagent[bot] wants to merge 3 commits into
feat/4270-repeated-bounce-request-wirefrom
feat/4284-camera-preset-parity
Closed

feat(rate-of-closure): add canonical camera preset parity#4358
d-sorgcodexagent[bot] wants to merge 3 commits into
feat/4270-repeated-bounce-request-wirefrom
feat/4284-camera-preset-parity

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Summary

  • define one strict shared-golden Python/TypeScript camera preset contract in the canonical x-downrange/y-up/z-right frame
  • add matched accessible PyQt6 Club3DView and React ClubCanvas controls for Isometric, explicit-side Face On, Down the Line, Overhead, Reset View, and geometry-bounded Auto Fit
  • preserve zoom and target semantics, mark free orbit as custom, restore canonical state deliberately, and suppress only collapsed depth axes in exact PyQt engineering views

Validation

  • 929 Python/PyQt tests passed; 20 focused camera tests and 55 relevant GUI/layout tests passed after rendered-axis correction
  • 750 React tests across 118 files passed; focused camera contract/component tests, TypeScript, zero-warning ESLint, and 206-module production build passed
  • Ruff, Black, focused MyPy, manifest validation/tests, module-size and diff gates passed
  • rendered React interaction review and fresh PyQt Face On / DTL / Overhead / Isometric PNG review completed

Scope truth

This is the first preset/Auto Fit child only. Track Clubhead, tracking suspension/recenter, per-viewport workspace persistence, remaining 3D adapters, principal React 3D swing, Playwright/HiDPI/full playback matrix, protected review, release, and issue/epic completion remain open.

Refs #4284
Refs #4218

codex-scheduled added 2 commits August 11, 2026 12:53
No material handoff change: typing-only correction for PR #4358's existing camera contract; behavior and documented scope are unchanged.
@dieterolson

Copy link
Copy Markdown
Collaborator

Consolidated into #4410. Closing to reduce CI/CD runner load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant