perf(data-explorer): qualify SVG path construction - #4387
Conversation
Replaced intermediate string array allocations (`[].push()` -> `.join(' ')`)
with single-pass string concatenation for generating SVG path `d` strings
in `ScatterPlot`, `LinePlot`, and `SpectrumPlot`. This prevents massive
array allocations during high-frequency chart re-renders.
Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0877c38a3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d-sorgcodexagent
Bot
changed the title
|
Addressed the actionable review thread at exact head Local final-head evidence: 384/384 frontend tests, changed-file zero-warning ESLint, TypeScript, 1,589-module production build, docs governance, and diff hygiene pass. |
|
Consolidated into #4408. Closing to reduce CI/CD runner load. |
Pull request was closed
1 participant
What
SPEC.md.Evidence
On the repository-declared Node 24 runtime, all 384 P1AM frontend tests pass, changed-file ESLint is zero-warning, TypeScript passes, and the 1,589-module production build succeeds.
A post-warmup 30-sample local benchmark produced byte-identical old/new output. At 1,000/10,000/100,000 points, concatenation medians were 0.210/1.954/17.751 ms versus array/join 0.285/2.181/21.896 ms. At 100,000 points, median observed heap delta was 35.093 MiB versus 36.770 MiB. These are directional local measurements, not a cross-engine or GC-pause guarantee.
Release discipline
Human review is approved. Fresh exact-head checks and ordinary protected merge behavior remain required. This PR supersedes narrower duplicate #4386.