feat(rate-of-closure): produce paired localized attribution - #4426
Draft
d-sorgcodexagent[bot] wants to merge 11 commits into
Draft
feat(rate-of-closure): produce paired localized attribution#4426d-sorgcodexagent[bot] wants to merge 11 commits into
d-sorgcodexagent[bot] wants to merge 11 commits into
Conversation
added 10 commits
August 13, 2026 03:10
…42-localized-attribution-producer
…42-localized-attribution-producer # Conflicts: # AGENT_HANDOFF.md # SPEC.md # docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md # src/rate_of_closure/AGENT_HANDOFF.md
31 tasks
This was referenced Aug 13, 2026
Closed
dieterolson
pushed a commit
that referenced
this pull request
Aug 14, 2026
…esign seam Two slices in this family carry contracts that are mutually exclusive as written, and neither branch contained both, so both slices' tests passed in isolation and the contradiction only appears once they are integrated: - #4426 added `build_simulation_ensemble_request_from_samples`, whose entire purpose is deterministic experimental designs "whose rows are the scientific authority (for example, planted baseline/perturbation pairs), rather than pseudorandom Monte Carlo draws". - #4428/#4431 made `SimulationEnsembleRequest.__post_init__` require unconditionally that `sampled_inputs` equal `sample_inputs(plan)` -- the plan-derived RNG stream. Together, the request contract rejects exactly the designs the seam exists to carry. Measured: 7 tests in test_localized_attribution_producer.py failed with "sampled_inputs must exactly match the plan-derived RNG stream and order", which is the whole paired-attribution producer being non-functional. Reconciled by making the provenance explicit rather than implied. `SimulationEnsembleRequest.sample_provenance` defaults to `plan_rng`, so every existing caller and test keeps the reproducibility guarantee unchanged, and the RNG-stream equality check is enforced exactly as before. The explicit seam passes `explicit_design`, which skips only that one check; shape, finiteness, and crucially `_require_config_sample_binding` -- the check that actually proves each row was executed as written -- all still apply. The Monte Carlo seam now passes `plan_rng` explicitly, because it delegates through the explicit builder and must not inherit its default. Verified with the pinned toolchain: the 7 producer tests pass, and 626 tests across the variation, reference, flight, solver and impact suites pass with no new failures. Confirmed the 5 unrelated failures in this area are pre-existing on the pushed branch by re-running them with these two files reverted to HEAD.
dieterolson
pushed a commit
that referenced
this pull request
Aug 14, 2026
The repo-wide tooltip-completeness contract (test_tooltips.py) failed on eight widgets, all of them paired-attribution controls added by #4426/#4427: Cancel Paired Study, the two export buttons, and the save/load authority buttons. The tooltip contract comes from a different slice, so neither branch contained both and the gap only appears once they are integrated. Hints state what each control does and, where it matters, what it does not: cancelling publishes nothing but retains prior authority, the view export records what is displayed rather than the authority, and loading is accepted only if the archived design and request identities still validate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
eb97f55be9ed6593698bf24fac3681d883b51a47Honest boundary
This is a Python service authority. Automatic PyQt/React orchestration, Worker/document persistence, prescribed/Rust parity, and protected release remain open. No causal result is inferred from observational scatter, and no R10-R15 checkbox should be closed solely from this PR.