Skip to content

feat(rate-of-closure): keep primary visualizations above the fold - #4435

Draft
d-sorgcodexagent[bot] wants to merge 5 commits into
codex/4142-crossbrowser-pyqtfrom
codex/4433-visualization-tab-visibility
Draft

feat(rate-of-closure): keep primary visualizations above the fold#4435
d-sorgcodexagent[bot] wants to merge 5 commits into
codex/4142-crossbrowser-pyqtfrom
codex/4433-visualization-tab-visibility

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Summary

Advances #4433 with the visual-first visibility foundation for every registered React and PyQt primary tab.

  • inventories and governs all 18 primary surfaces through a strict, deeply immutable cross-runtime manifest
  • brings the primary visual or honest semantic preview into the initial viewport instead of requiring explanatory-text scrolling
  • fixes responsive ordering and layout at 1440x900, 1280x720, and 390x844
  • requires at least 240 px desktop and 180 px narrow visible height for visual landmarks, with meaningful width and ancestor-clipping checks
  • audits PyQt at 100% and 150% DPI with one diagnostic PNG per tab and prevents overlap with interactive controls
  • sustains the rendered gate in hosted PR and trusted main-push workflows with exact authority-path routing

Stack

Evidence

  • React Vitest: 895 passed
  • production Chromium visibility audit: 2 passed across all manifest viewports
  • Python/PyQt/workflow/manifest: 34 passed, including 9 PyQt tabs at both DPI scales and 18 per-tab artifacts
  • TypeScript, ESLint, Vite production build, Ruff, Python 3.12 Mypy, actionlint 1.7.12, docs governance, size and diff checks: green
  • two independent exact-head reviews: GO

Honest boundary

This does not close #4433. It establishes initial-view visibility and durable audit governance. Shared visualization interaction patterns, complete empty/loading/result/error geometry, approved visual goldens, formal assistive-technology review, user approval, downstream validation, and protected landing remain open.

Human review approval was provided in the coordinating task; GitHub still needs to record whatever formal review/protection state the repository requires.

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor Author

Protected-head correction evidence

PR #4435 now points to exact 4dde158109d85df2bf876d73f0c384d482fb989d.

The two actionable hosted failures on earlier heads are closed:

  • the mobile toolstrip now shrinks its command strip locally rather than widening the document; the full 11-scenario Chromium/Firefox/WebKit production suite passed locally and the protected Rate web production Worker E2E is now SUCCESS;
  • the exact PyQt subprocess support probe is narrowly assertion-policy allowlisted with an adjacent negative policy regression; protected quality-gate is now SUCCESS;
  • clean Python 3.12 .[gui,dev] installation now declares the full-window direct pandas/SciPy/SymPy runtime closure, imports RateOfClosureMainWindow, and passes the 100%/150% PyQt visibility test.

No terminal check failures remain on this head. Eleven fleet-routed contexts are still queued; the PR remains draft with no recorded formal review decision, so this is protected-check progress, not merge completion. #4433 remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants