Skip to content

feat(rate-of-closure): add Sasho rotational AoA option - #4436

Merged
d-sorgcodexagent[bot] merged 2 commits into
codex/4142-localized-react-executionfrom
agent/sasho-face-center-rotational-aoa
Aug 13, 2026
Merged

feat(rate-of-closure): add Sasho rotational AoA option#4436
d-sorgcodexagent[bot] merged 2 commits into
codex/4142-localized-react-executionfrom
agent/sasho-face-center-rotational-aoa

Conversation

@d-sorgcodexagent

@d-sorgcodexagent d-sorgcodexagent Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Sasho's nearest-shaft face-center rotational AoA as a stable third method beside the remove-shaft counterfactual and two-factor Shapley attribution
  • compute Q = A + s(s dot (F-A)), v = omega x (F-Q), then signed AoA from the vertical and horizontal components of v
  • expose the metric, full numerical provenance, and independently selectable velocity vector in React and PyQt6
  • retain method ID, complete angular velocity, nearest point, lever, velocity components, and AoA in strict impact-scene v3 export
  • pin Python/TypeScript parity to an exact shared golden and explicitly label the result descriptive, non-additive, and noncausal

Stack

Verification

  • python -m pytest tests/rate_of_closure -q — 1,222 passed
  • python -m pytest tests/shared/python/golf_club -q — 175 passed, 2 optional build123d skips
  • full Rate React Vitest — 110 files / 877 tests passed
  • Python 3.12 + pinned Mypy 1.13 on seven changed production Python modules — success
  • Ruff check/format, TypeScript, zero-warning ESLint, Vite production build, docs governance, changed-test assertions, detect-secrets, changed-source size, and diff checks — green

Scientific boundary

The Sasho option intentionally uses complete club angular velocity. It is not equal to the existing shaft-axis-only removal unless non-shaft angular velocity contributes zero at the face-center lever. It is a descriptive rotation-only AoA, not an additive or causal decomposition, and it does not alter collision or ball-flight physics.

Closes #4434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants