Skip to content

feat(rate): add synchronized flight sample inspector - #4451

Draft
d-sorgcodexagent[bot] wants to merge 2 commits into
codex/4433-club-explorer-camerafrom
codex/4433-flight-sample-inspector
Draft

feat(rate): add synchronized flight sample inspector#4451
d-sorgcodexagent[bot] wants to merge 2 commits into
codex/4433-club-explorer-camerafrom
codex/4433-flight-sample-inspector

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Part of #4433.

What changed

  • Adds immutable accepted-flight bundles with complete execution context, bounded exact sample plans, and atomic retained-result publication.
  • Adds synchronized raw-sample inspection across React side/top plots, React 3D playback, and the PyQt flight view using pointer and keyboard controls.
  • Makes retained-flight authority explicit after scientific input edits and keeps presentation-only unit changes identity-preserving.
  • Adds product-driven React result prominence, focus/status semantics, deterministic PyQt rendered evidence, and protected workflow/manifest governance.
  • Keeps calm comparison display-only and primary trajectory inspection runtime-local; no cross-runtime solver-sample identity is claimed.

Verification

  • Independent exact-SHA review: GO on aa34548fb91814c08e8fd227cfaf5c80cfdf1bfb.
  • Web: 123 files / 1,044 tests green; type-check, ESLint, and production build green.
  • Browser lifecycle: 3/3 at 1440x900, 1280x720, and 390x844.
  • PyQt rendered lifecycle: 2/2 at DPI 1.0/1.5 with readable deterministic fonts and retained-canvas checks.
  • Workflow/manifest/assertion governance: 45/45.
  • Python 3.12 / MyPy 1.13 scoped source gate: 13 files, 0 issues; Ruff and format clean.
  • Focused accepted-study/planner/atomic GUI lanes are green; all changed source/tests are <=400 lines.

Broad-suite limitation

The serial full Rate Python suite remained CPU-active but hit the 904 s ceiling without a failure summary. A parallel run reached 1,168 passes before an unrelated Morris child-readiness timeout under load; that exact Morris test passed 1/1 in isolation. A replacement excluding it reached the tool ceiling without a terminal summary. No broad rerun was issued. Scoped Flight, rendered, static, governance, and full web gates are green.

Open boundaries

Diagnostic captures are not approved goldens. Portable flight archive identity, formal assistive-technology qualification, calm-ghost inspection, 3D camera keyboard parity, async/cancel semantics, and the remaining visualization tabs stay open under #4433.

@dieterolson

Copy link
Copy Markdown
Collaborator

Blocker: this branch commits six orphan gitlinks

git ls-tree -r on this branch shows six entries at mode=160000 type=commit — git submodule references — under .codex-worktrees/:

.codex-worktrees/friction-factors-3659
.codex-worktrees/pr-3602-fix
.codex-worktrees/pr-3752-movement
.codex-worktrees/pr-3766-modern-robotics-dbc
.codex-worktrees/pr-3780-pressure-flow
.codex-worktrees/pr-3784-deterministic-te

There is no .gitmodules on the branch, so nothing defines where these submodules come from. They are scratch Codex worktrees that got committed as gitlinks. Landing them would break git clone --recurse-submodules and any checkout with submodules enabled, and they point at commits that may exist only in a local worktree.

This is corroborated independently: #4473's description states it is a "clean scoped rebuild" that excludes, among other things, "six scratch-worktree gitlinks" — the same six.

Scope observation

Measured against the union of main and the four campaign branches (#4446, #4447, #4466, #4473), this branch's tree of ~5,950 files contains no source paths that exist nowhere else — the only unique paths are the gitlinks above. So the real work here is modifications to files the campaign branches already carry, not new modules, and this reads as one layer of a stack rather than an independent change.

Path-level containment is not content-level containment, so this is not a claim that the work is already covered — the per-file content still needs checking before anything here is closed. Recording it now so the gitlinks are dealt with first either way.

Suggested next step

Remove the .codex-worktrees/ gitlinks from the branch (git rm --cached each path) before this leaves draft. Per the decision on the #4447/#4473 collision, the campaign is landing via #4446/#4447/#4466, so it is also worth confirming what this branch still adds on top of those once they merge.

No action taken on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant