Skip to content

feat(rate): bind Simulation scrub execution authority - #4452

Closed
d-sorgcodexagent[bot] wants to merge 1 commit into
codex/4433-flight-sample-inspectorfrom
codex/4433-simulation-scrub-authority
Closed

feat(rate): bind Simulation scrub execution authority#4452
d-sorgcodexagent[bot] wants to merge 1 commit into
codex/4433-flight-sample-inspectorfrom
codex/4433-simulation-scrub-authority

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Summary

  • execute the exact React Simulation impact-time candidate on pointer release, keyboard range commits, and Auto tau
  • retain the prior accepted scene (or an honest empty state) on bounded synchronous execution failure
  • preserve and regression-test the already-correct PyQt keyboard/Auto behavior, with successful-run publication extracted below the 400-line source ceiling
  • correct Simulation lifecycle manifest wording and add production Chromium plus two-DPI PyQt diagnostic evidence
  • extend protected workflow path/command authority and advance the four canonical handoff/SPEC documents to 1.16.95

Root cause

React Auto tau called setTauMs(null) and immediately reran through a closure that still held the prior value. The range also reran only from mouse/touch handlers, so keyboard adjustments changed the editor without executing that exact candidate.

Validation

  • full web: 124 files / 1,046 tests
  • scoped Python Simulation, ball-setup, and manual-delivery lane: 107/107
  • governance/assertion/workflow/manifest lane: 47/47
  • Chromium production viewport evidence: 3/3 (1440x900, 1280x720, 390x844)
  • PyQt rendered evidence: 2/2 (DPI 1.0 and 1.5), with identical accepted canvas hashes after planted dependency failure
  • Vite build, TypeScript, ESLint, Ruff lint/format, pinned Python 3.12 MyPy 1.13, module-size, diff-check, and <=400 changed-source/test checks: green

Boundaries

Execution remains synchronous in both surfaces; this change does not invent loading, progress, or cancel states. Rendered PNGs are diagnostic rather than approved goldens. Formal AT approval, performance qualification, and the remaining #4433 tab work stay open.

@dieterolson

Copy link
Copy Markdown
Collaborator

Blocker: this branch commits six orphan gitlinks

git ls-tree -r on this branch shows six entries at mode=160000 type=commit — git submodule references — under .codex-worktrees/:

.codex-worktrees/friction-factors-3659
.codex-worktrees/pr-3602-fix
.codex-worktrees/pr-3752-movement
.codex-worktrees/pr-3766-modern-robotics-dbc
.codex-worktrees/pr-3780-pressure-flow
.codex-worktrees/pr-3784-deterministic-te

There is no .gitmodules on the branch, so nothing defines where these submodules come from. They are scratch Codex worktrees that got committed as gitlinks. Landing them would break git clone --recurse-submodules and any checkout with submodules enabled, and they point at commits that may exist only in a local worktree.

This is corroborated independently: #4473's description states it is a "clean scoped rebuild" that excludes, among other things, "six scratch-worktree gitlinks" — the same six.

Scope observation

Measured against the union of main and the four campaign branches (#4446, #4447, #4466, #4473), this branch's tree of ~5,950 files contains no source paths that exist nowhere else — the only unique paths are the gitlinks above. So the real work here is modifications to files the campaign branches already carry, not new modules, and this reads as one layer of a stack rather than an independent change.

Path-level containment is not content-level containment, so this is not a claim that the work is already covered — the per-file content still needs checking before anything here is closed. Recording it now so the gitlinks are dealt with first either way.

Suggested next step

Remove the .codex-worktrees/ gitlinks from the branch (git rm --cached each path) before this leaves draft. Per the decision on the #4447/#4473 collision, the campaign is landing via #4446/#4447/#4466, so it is also worth confirming what this branch still adds on top of those once they merge.

No action taken on this branch.

@dieterolson

Copy link
Copy Markdown
Collaborator

Closing as superseded by #4473 (CONS-RATE: Complete #4142/#4433 visualization authority), merged 2026-08-16 as 392d9683b.

#4473 states in its own description: "After protected merge, this PR supersedes only the remaining #4142/#4433 draft chain." That merge has landed.

Verified before closing:

The branch is left intact, so nothing is lost and this can be reopened if any slice turns out to be missing. Please reopen rather than rebase — rebasing this chain onto current main would reintroduce the divergence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant