Skip to content

feat(rate): add bounded plot evidence inspector - #4453

Draft
d-sorgcodexagent[bot] wants to merge 1 commit into
codex/4433-simulation-scrub-authorityfrom
codex/4433-plots-computation-authority
Draft

feat(rate): add bounded plot evidence inspector#4453
d-sorgcodexagent[bot] wants to merge 1 commit into
codex/4433-simulation-scrub-authorityfrom
codex/4433-plots-computation-authority

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Adds bounded, cached Plots computation and matched React/PyQt exact point and derived histogram-bin inspection. Failed recomputation retains prior accepted data, selection, pixels, and export authority. Evidence: focused Python/PyQt 62/62, React 24/24, full web and build green, Python 1425/1425 excluding one separately green load-sensitive Club timing benchmark, Chromium 3/3, PyQt DPI 2/2, and hosted-shaped MyPy/Ruff/ESLint/type-check/governance green. Artifacts remain diagnostic; #4433 stays open for approved goldens, formal AT, portability, and remaining work.

@dieterolson

Copy link
Copy Markdown
Collaborator

Blocker: this branch commits six orphan gitlinks

git ls-tree -r on this branch shows six entries at mode=160000 type=commit — git submodule references — under .codex-worktrees/:

.codex-worktrees/friction-factors-3659
.codex-worktrees/pr-3602-fix
.codex-worktrees/pr-3752-movement
.codex-worktrees/pr-3766-modern-robotics-dbc
.codex-worktrees/pr-3780-pressure-flow
.codex-worktrees/pr-3784-deterministic-te

There is no .gitmodules on the branch, so nothing defines where these submodules come from. They are scratch Codex worktrees that got committed as gitlinks. Landing them would break git clone --recurse-submodules and any checkout with submodules enabled, and they point at commits that may exist only in a local worktree.

This is corroborated independently: #4473's description states it is a "clean scoped rebuild" that excludes, among other things, "six scratch-worktree gitlinks" — the same six.

Scope observation

Measured against the union of main and the four campaign branches (#4446, #4447, #4466, #4473), this branch's tree of ~5,950 files contains no source paths that exist nowhere else — the only unique paths are the gitlinks above. So the real work here is modifications to files the campaign branches already carry, not new modules, and this reads as one layer of a stack rather than an independent change.

Path-level containment is not content-level containment, so this is not a claim that the work is already covered — the per-file content still needs checking before anything here is closed. Recording it now so the gitlinks are dealt with first either way.

Suggested next step

Remove the .codex-worktrees/ gitlinks from the branch (git rm --cached each path) before this leaves draft. Per the decision on the #4447/#4473 collision, the campaign is landing via #4446/#4447/#4466, so it is also worth confirming what this branch still adds on top of those once they merge.

No action taken on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant