Skip to content

Lukass/introduce test mode - #25

Open
SzymonLukasik wants to merge 12 commits into
masterfrom
lukass/introduce_test_mode
Open

Lukass/introduce test mode#25
SzymonLukasik wants to merge 12 commits into
masterfrom
lukass/introduce_test_mode

Conversation

@SzymonLukasik

Copy link
Copy Markdown
Collaborator
  • train_and_validate refactor
  • demo notebook with training and test run from command line

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Comment thread src/train_and_validate.py
)
parser.add_argument(

subparsers = parser.add_subparsers(help="Train or test a model.", dest="mode")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagined that we add 3 subparsers.

  1. validate to do cross validation, so the process that was done previously in train_and_validate.py.
    • input: method, config
    • output: metrics, and trained model weights (if there was set the option retrain)
  2. train to do only training on the whole dataset. So only the last step that was done during cross validation.
    • input: method, config
    • output: trained model weights, and according to task formulation: a table where each cell will be assigned cell-type probabilities (if available) and a final cell-type prediction
  3. test / predict
    • input: method, pretrained model weights
    • output: metrics, and according to task formulation: a table where each cell will be assigned cell-type probabilities (if available) and a final cell-type prediction

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because to fulfill task requirements 'pre-train baselines and state-of-the-art methods on new data' we don't need cross validation

@SzymonLukasik
SzymonLukasik force-pushed the lukass/introduce_test_mode branch from 635cc71 to 1d00226 Compare May 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants