Repository navigation
Release v0.3.2: tolerant transition-array check; c_trtB erratum docs - #6
Merged
Merged
Conversation
The array branch compared each cycle's sum of transition probabilities with n_states using exact equality, so rounding error could reject a valid array. Use all.equal(), as in darthtools. No effect on this tutorial's results (it only checks matrices); the same bug stopped the state-residence PSA in cohort-modeling-tutorial-timedep.
✅ Deploy Preview for testcohort ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small release. No change to this tutorial's results.
check_sum_of_transition_array()compared each cycle's transition-array sum withn_statesusing exact==, so rounding error could reject a valid array. It now usesall.equal(), as darthtools does. This tutorial only checks matrices, so it isn't affected, but the same bug stopped the state-residence PSA in cohort-modeling-tutorial-timedep (fixed there in v0.3.0).c_trtBparameter-table erratum documentation and PSA-means test from Document c_trtB parameter-table erratum (closes #1) #5 (closes Parameter table prints c_trtB = $12,000; the analysis code and the published results use $13,000 #1) in a release.