You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Progress bars are never closed (R/run_dsa.R:119, R/run_dsa.R:289): add on.exit(close(pb)).
rdirichlet() roxygen tags are indented and therefore ignored (R/gen_psa_samp.R:273-275, #' @importFrom / #' @return / #' @export). Reproduced: dampack::rdirichlet is "not an exported object". Decide whether to export it or mark it @keywords internal, then fix the indentation.
Acceptance
devtools::check() shows no new NOTEs.
Running the tests with options(lifecycle_verbosity = "error") raises no ggplot2/scales deprecation warnings.
seq_len() changes are covered by existing tests, plus at least one 0-length test where reachable.
Done in #224 (merged Nov 13, 2026), with the NEWS entry in #240: qualified cor() import, ggplot2's transform and scales::new_transform() (with minimum versions ggplot2 ≥ 3.5.0 and scales ≥ 1.3.0), .groups moved out of group_by(), seq_len()/seq_along() loops, progress bars closed, and the rdirichlet() roxygen fixed. rdirichlet() stays internal (@keywords internal), which matches what the NAMESPACE has always done; if the team prefers to export it, that can be a one-line follow-up.
Activity
Code hygiene: imports, modern ggplot2/scales APIs, safe loops (DARTH-…
Merge pull request #224 from IG-ABHINAV/211-code-hygiene
feralaes commentedon Nov 13, 2026
Done in #224 (merged Nov 13, 2026), with the NEWS entry in #240: qualified
cor()import, ggplot2'stransformandscales::new_transform()(with minimum versions ggplot2 ≥ 3.5.0 and scales ≥ 1.3.0),.groupsmoved out ofgroup_by(),seq_len()/seq_along()loops, progress bars closed, and therdirichlet()roxygen fixed.rdirichlet()stays internal (@keywords internal), which matches what the NAMESPACE has always done; if the team prefers to export it, that can be a one-line follow-up.