Repository navigation
CI: test the minimum R version declared in DESCRIPTION - #249
Merged
Merged
Conversation
… DESCRIPTION DESCRIPTION declares R (>= 4.1.0), but no job ran R 4.1: oldrel-1 and the min-deps job use current R. The min-deps job now has a matrix entry that reads the R bound from DESCRIPTION and checks the package on that version with the minimum package versions.
…or repositories R 4.1 on ubuntu-latest (Ubuntu 26) failed while resolving dependencies: the Bioconductor 3.14 repositories pak adds for R 4.1 are unreachable, and the package manager has no R 4.1 binaries for Ubuntu 26. dampack uses no Bioconductor packages.
The new minimum-R CI job could not install the dependencies on R 4.1.0: 'triangle: Needs R >= 4.1.3'. Raise the declared bound to what installs from CRAN, and let the job confirm that nothing else needs a newer R.
R CMD check warns 'Dependence on R version 4.1.3 not with patchlevel 0', which CRAN does not accept. On R 4.1.3 every other check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION said
R (>= 4.1.0), but no CI job ran R 4.1.oldrel-1and the minimum-dependency job both use a recent R.Changes
CI: the minimum-dependency workflow now runs twice:
DESCRIPTION:
R (>= 4.2.0). The new job showed that the old bound wasn't true:triangle: Needs R >= 4.1.3.Dependence on R version '4.1.3' not with patchlevel 0, and CRAN doesn't accept that warning.So the bound is now the first x.y.0 release that works. NEWS says so.
This job isn't in the branch-protection required checks.
Part of #213 / #219.