Integrate master into dev - #748
Conversation
* workaround for dasvader HDF2 compatibility issue. * address first review * address review 2
Co-authored-by: Derrick UCD <derrick.chambers@ucd.ie>
* allow array_likes to pass through patch creation * clean up * address review
* fix hampel bottleneck median centering * Address moving median review feedback
* added support for OptoDAS v11. That format has no changes relevant to DAScore, so this is a simple fix * added the V11 class import, and added to plugins * Added missing OptoDASV9 to the __init__.py
* fixed sampling rate determination for older versions <1 * set 'data_units' and 'data_type' attributes * removed superflous empty lines * fixed again for Valencia data. different approach now to fix pre-2021 formats * try a different approach to satisfy CODEDEV checks
* Added typical IDE project files to be ignored by git * Update .gitignore * removed duplicate PyCharm ".idea/" reference in gitignore
* axis lables are now capitalised, and unit in square brackets * fixed time axis label and test suite * updated waterfall test to be case-insentive
* new patch functions for demean and demedian * Update basic.py * fixed docstring * suppress output in examples to satisfy testing * incorporated axis-improvements suggested by Coderabbit * Update tests for demean/demedian to make it independent of dimension * fixed bug that was suggested by coderabbit * fix comment median >> mean * minor cleanup of redundand np.array call * fixed indetation issue (hopefully) * fixed typo in comment
* fix minor febus linting issues * ensure lint runs on PR
* small tweaks for agents * address review
* add *args and **kwargs to rolling.apply * add example to apply for rolling
* add more details about making a release * address review
Added STALTA, FBE, and Kurtosis transforms This works now also the with latest upgrade of the "rolling" function to allow for arguments being passed #689 numba implementation to speed up significantly --------- Co-authored-by: Derrick Chambers <d-chambers@users.noreply.github.com>
* waterfall now has default colormaps for various datatypes. Colorbar also shows extend triangles if appropriate * fixed typo in docstring * default cmap --------- Co-authored-by: Derrick Chambers <chambers.ja.derrick@gmail.com>
* add cbar back to waterfall, cmap=None default again * address review
Logic for loading Febus T1 data --------- Co-authored-by: Shawn Boltz <mboltz@cdc.gov>
* febus BSL h5 read support * Address BSL review comments * Rename BSL HDF5 reader class
* added output type to dtf; data_type is now 'fourier transform' * applied coderabits suggestions * fixed maybe_units labels for plots with ft-axis * Fix DFT spectral output scaling * address review, ensure lint runs only once * refactor, cover missing line * keep one-sided spectra * minor typo in error message * minor typo in error message in test_fourier --------- Co-authored-by: Derrick Chambers <chambers.ja.derrick@gmail.com>
* Fix DASDAE FileSpool patch attribute loading * Ignore null DASDAE attr filters
* Defer matplotlib import by lazily loading dascore.viz
Integrate latest master (through #744) into the dev branch. Conflicts were resolved giving dev's feature/architecture changes priority (merge -X ours), while incorporating master's non-conflicting work. The deprecated transform/fft.py and transform/spectro.py (removed in dev's API cleanup and replaced by fourier.py / viz.spectrogram) were kept deleted per dev's architecture.
Add an explicit ns precision to the remaining np.datetime64/np.timedelta64 call sites that lacked one. Notably summary.py's flat-dump null-step sentinel used a bare timedelta64(NaT) (numpy 2.5 treats unitless NaT inconsistently), and the 0-D degenerate-array branches in utils/time.py returned datetime64/ timedelta64 with whatever precision the input carried instead of normalizing to ns like the sibling array branches.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe changes enforce explicit nanosecond precision across NumPy datetime and timedelta conversions, summary sentinels, and Sentek filename parsing. A test also verifies unknown-format handling for empty HDF5 files. ChangesNanosecond precision and format detection
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #748 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 163 163
Lines 17087 17087
=======================================
Hits 17081 17081
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The added 'if not keys: continue' check is unreachable: the preceding 'if not unsorted: continue' already skips formats with no loaded fiber_ios (_format_version is a defaultdict(dict), so a failed/absent format yields an empty dict). Dropping the dead branch restores full patch coverage.
Summary
Integrates the latest
master(through #744) intodev. Becausemaster's history was rebased at some point, its commits no longer share ancestry with the copiesdevpreviously absorbed via the "Merge master into dev" squashes, so a flatten-rebase is unsafe. Instead this is a merge ofmasterintodevwith conflicts resolved indev's favor (merge -X ours), keeping dev's feature/architecture work while pulling in master's non-conflicting changes.origin/devis an ancestor of this branch, so landing it is a fast-forward.What's included
transform/fft.pyandtransform/spectro.py(replaced byfourier.py/viz.spectrogram).nsunit when constructingnp.datetime64/np.timedelta64, closing the remaining unitless call sites (notably the flat-dump null-step sentinel incore/summary.pyand the 0-D degenerate-array branches inutils/time.py). This avoids the numpy 2.5 unitless-NaTinconsistency.Verification
origin/devandmasterare both fully contained; the merge commit has both parents. No commits lost from either side.Summary by CodeRabbit
Bug Fixes
Tests
Changelog
none