Merge master into dev

.agents/skills/draft-release/SKILL.md

@@ -14,13 +14,19 @@ Draft the next release version and changelog from merged PRs.
 
 ## Workflow
 
-0. Ask for elevated permissions with network access to run `git fetch --all --tags` and the GitHub CLI PR commands used to collect merged PRs (for example `gh pr list`, `gh pr view`, or `gh api`).
-1. Fetch the latest refs and tags:
+0. Ask for elevated permissions with network access to run the `git fetch` and GitHub CLI PR commands used to collect merged PRs (for example `gh pr list`, `gh pr view`, or `gh api`).
+1. Fetch the latest refs and tags from `origin` only. Do **not** use
+   `git fetch --all` — it also fetches unrelated remotes (e.g. a personal fork or
+   another contributor's remote) and can fail on those or clobber local tags,
+   aborting the whole fetch:
 
 ```bash
-git fetch --all --tags
+git fetch --tags origin
 ```
 
+   If you only need to read the tags without touching local state, use
+   `git ls-remote --tags origin` instead.
+
 2. Determine the next version number:
 - Consider only tags that start with `v` and match strict semver:
   `^v[0-9]+\.[0-9]+\.[0-9]+$` (ignore pre-release/build suffixes).
@@ -45,18 +51,32 @@ git fetch --all --tags
 - `Bug Fixes`
 - `Breaking Changes`
 
-5. Classify PRs deterministically:
-- `Breaking Changes` if any of:
-  - title contains `!` in conventional-commit style segment, or
-  - label indicates breaking change (e.g., `breaking`), or
-  - body contains `BREAKING CHANGE`.
-- Otherwise `New Features` if labels/titles indicate feature work
-  (e.g., `feature`, `enhancement`, `feat`).
+5. Drop reverted pairs first. If a PR in scope reverts another PR that is also
+   in scope (revert PRs usually say "Revert ..." and name the reverted PR or
+   commit in the title/body), the two cancel out to no net user-facing change.
+   Omit both from the sections and instead list them under a short
+   `Reverted (no net change)` note at the end, so the reader knows why those PR
+   numbers are absent.
+
+6. Classify the remaining PRs. This repo does not use conventional-commit
+   markers, and its labels are topical (`proc`, `viz`, `spool`, `IO`,
+   `transform`, `bug`, ...) rather than semantic, so labels alone are not
+   enough — read each PR's title and body and use judgment:
+- `Breaking Changes` if the change removes or alters existing public API,
+   defaults, or behavior in a way that can break callers — regardless of whether
+   any `!`, `breaking` label, or `BREAKING CHANGE` text is present. A signature
+   or keyword change to a documented `Patch`/`dc` method is breaking even when
+   unlabeled; when unsure, list it here with a one-line note on what changed.
+- Otherwise `New Features` if the PR adds a capability, option, or notable
+   performance improvement (judge from the title/body, not just a
+   `feature`/`enhancement` label, which is often missing).
 - Otherwise `Bug Fixes`.
-- Sort entries by PR number ascending.
+- Prefer user-facing behavior over internal implementation when deciding and
+   when summarizing.
+- Sort entries within each section by PR number ascending.
 - Include a link to the PR in the changelog.
 
-6. Print to screen:
+7. Print to screen:
 - The new version tag.
 - The drafted changelog.
 
@@ -73,6 +93,8 @@ Next Version: vX.Y.Z
 
 ## Breaking Changes
 - #125: Short summary (https://github.com/OWNER/REPO/pull/125)
+
+Reverted (no net change): #126 reverted by #127
 ```
 
 ## Notes
@@ -81,3 +103,4 @@ Next Version: vX.Y.Z
 - Prefer explicit, user-facing PR summaries over internal implementation details.
 - If no merged PRs are found in scope, still print the next version and include
   all sections with `- None`.
+- Omit the `Reverted (no net change)` line when no reverted pairs exist.

.github/actions/mamba-install-dascore/action.yml

@@ -37,7 +37,7 @@ runs:
       shell: bash -l {0}
       run: echo "CURRENT_DATE=$(date '+%Y-%m-%d')" >> $GITHUB_ENV
 
-    - uses: mamba-org/setup-micromamba@v2
+    - uses: mamba-org/setup-micromamba@v3
       with:
         micromamba-version: '2.0.5-0' # versions: https://github.com/mamba-org/micromamba-releases
         environment-file: ${{ inputs.environment-file }}
@@ -85,7 +85,7 @@ runs:
     - name: restore test data cache
       if: "${{ inputs.prepare-test-data == 'true' }}"
       id: restore-test-data
-      uses: actions/cache/restore@v4
+      uses: actions/cache/restore@v5
       with:
         path: ${{ env.DATA_CACHE_PATH }}
         key: ${{ env.DATA_CACHE_KEY }}
@@ -97,7 +97,7 @@ runs:
 
     - name: save test data cache
       if: "${{ inputs.prepare-test-data == 'true' && steps.restore-test-data.outputs.cache-hit != 'true' }}"
-      uses: actions/cache/save@v4
+      uses: actions/cache/save@v5
       with:
         path: ${{ env.DATA_CACHE_PATH }}
         key: ${{ env.DATA_CACHE_KEY }}

.github/workflows/build_deploy_master_docs.yaml

@@ -31,7 +31,7 @@ jobs:
       name: github-pages
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'

.github/workflows/build_deploy_stable_docs.yaml

@@ -26,7 +26,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'

.github/workflows/get_coverage.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'
@@ -29,7 +29,7 @@ jobs:
         run: |
           pytest -s --cov dascore --cov-report=xml
 
-      - uses: codecov/codecov-action@v4
+      - uses: codecov/codecov-action@v5
         with:
           fail_ci_if_error: true
           files: ./coverage.xml

.github/workflows/lint.yml

@@ -16,7 +16,7 @@ jobs:
     if: github.event_name == 'push' || !contains(github.event.pull_request.labels.*.name, 'no_ci')
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'

.github/workflows/profile.yml

@@ -27,7 +27,7 @@ jobs:
       contains(github.event.pull_request.labels.*.name, 'benchmark')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'

.github/workflows/run_min_dep_tests.yml

@@ -34,7 +34,7 @@ jobs:
       python-matrix: ${{ steps.load-vars.outputs.python-min-deps-matrix }}
       os-matrix: ${{ steps.load-vars.outputs.test-os-matrix }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ./.github/actions/load-shared-vars
         id: load-vars
 
@@ -58,7 +58,7 @@ jobs:
       PYTEST_ADDOPTS: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'debug') && '-vv --durations=100' || '' }}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'

.github/workflows/runtests.yml

@@ -38,7 +38,7 @@ jobs:
       python-matrix: ${{ steps.load-vars.outputs.python-test-matrix }}
       os-matrix: ${{ steps.load-vars.outputs.test-os-matrix }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ./.github/actions/load-shared-vars
         id: load-vars
 
@@ -63,7 +63,7 @@ jobs:
       PYTEST_ADDOPTS: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'debug') && '-vv --durations=100' || '' }}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: 'true'
           fetch-depth: '0'
@@ -109,7 +109,7 @@ jobs:
           limit-access-to-actor: true
 
       # Upload coverage files
-      - uses: codecov/codecov-action@v4
+      - uses: codecov/codecov-action@v5
         with:
           fail_ci_if_error: false
           files: ./coverage.xml

.github/workflows/test_doc_build.yml

@@ -15,7 +15,7 @@ jobs:
       || (github.event.action == 'synchronize' && contains(github.event.pull_request.labels.*.name, 'documentation'))
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'

.github/workflows/upload_pypi.yml

@@ -9,7 +9,7 @@ jobs:
   upload:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-tags: "true"
           fetch-depth: '0'

benchmarks/test_patch_benchmarks.py

@@ -88,6 +88,16 @@ def test_select(self, example_patch):
         patch.select(time=(t1, None))
         patch.select(time=(t1, t2))
 
+    @pytest.mark.benchmark
+    def test_update_existing_coords(self, example_patch):
+        """Time update_coords re-passing already-validated BaseCoords."""
+        patch = example_patch
+        coords = patch.coords
+        patch.update_coords(
+            time=coords.coord_map["time"],
+            distance=coords.coord_map["distance"],
+        )
+
     @pytest.mark.benchmark
     def test_sobel_filter(self, example_patch):
         """Time the Sobel filter."""
@@ -113,6 +123,18 @@ def test_transpose(self, example_patch):
         dims = patch.dims[::-1]
         patch.transpose(*dims)
 
+    @pytest.mark.benchmark
+    def test_transpose_noop(self, example_patch):
+        """Time a no-op transpose (same dimension order)."""
+        patch = example_patch
+        patch.transpose(*patch.dims)
+
+    @pytest.mark.benchmark
+    def test_squeeze_noop(self, example_patch):
+        """Time a no-op squeeze (no length-1 dimensions)."""
+        patch = example_patch
+        patch.squeeze()
+
     @pytest.mark.benchmark
     def test_roll(self, example_patch):
         """Time roll/shift operations."""
@@ -125,6 +147,12 @@ def test_snap_coords(self, patch_uneven_time):
         patch = patch_uneven_time
         patch.snap_coords("time")
 
+    @pytest.mark.benchmark
+    def test_snap_coords_already_even(self, example_patch):
+        """Time snapping an already even/sorted patch (no-op fast path)."""
+        patch = example_patch
+        patch.snap_coords("time", "distance")
+
     @pytest.mark.benchmark
     def test_hampel_filter_non_approximate(self, example_patch):
         """Time the Hampel filter."""

dascore/core/coordmanager.py

@@ -52,7 +52,12 @@
 from typing_extensions import Self
 
 from dascore.constants import dascore_styles, select_values_description
-from dascore.core.coords import BaseCoord, CoordSummary, get_coord
+from dascore.core.coords import (
+    BaseCoord,
+    CoordRange,
+    CoordSummary,
+    get_coord,
+)
 from dascore.exceptions import (
     CoordDataError,
     CoordError,
@@ -372,6 +377,9 @@ def _sort_related(name, dim, indexer, new_coords):
         cmap = self.coord_map
         assert set(coords).issubset(set(cmap))
         coords2sort = {x: cmap[x] for x in coords if not getattr(cmap[x], attr)}
+        # Nothing to sort; return self to avoid rebuilding an identical manager.
+        if not coords2sort:
+            return self, array
         new_coords, indexers = _get_dimensional_sorts(coords2sort)
         if array is not None:
             for index in indexers:
@@ -401,10 +409,17 @@ def snap(
         coords = self.dims if len(coords) == 0 else coords
         cm, array = self.sort(*coords, array=array, reverse=reverse)
         # now the arrays are sorted it should be correct to snap dimensions.
-        cmap = dict(cm.coord_map)
+        # Only collect coords whose snap actually changes them so an already
+        # even manager is returned unchanged (snap returns self when even).
+        updates = {}
         for coord_name in coords:
-            cmap[coord_name] = cmap[coord_name].snap()
-        out = cm.new(coord_map=cmap)
+            current = cm.coord_map[coord_name]
+            snapped = current.snap()
+            if snapped is not current:
+                updates[coord_name] = snapped
+        if not updates:
+            return cm, array
+        out = cm.new(coord_map={**cm.coord_map, **updates})
         assert out.shape == self.shape
         return out, array
 
@@ -851,6 +866,9 @@ def _get_transpose_dims(new, old):
             return tuple(new_list)
 
         dims = _get_transpose_dims(new=dims or self.dims[::-1], old=self.dims)
+        # No-op transpose; return self rather than rebuilding an equal manager.
+        if dims == self.dims:
+            return self
         return self.new(dims=dims)
 
     def rename_coord(self, **kwargs) -> Self:
@@ -919,6 +937,9 @@ def squeeze(self, dim: Sequence[str] | None = None) -> Self:
                 msg = f"cant squeeze dim {name} because it has non-zero length"
                 raise CoordError(msg)
             to_drop.append(name)
+        # Nothing to squeeze; return self rather than rebuilding an equal manager.
+        if not to_drop:
+            return self
         return self.drop_coords(*to_drop)[0]
 
     def decimate(self, **kwargs) -> tuple[Self, tuple[slice, ...]]:
@@ -1186,6 +1207,15 @@ def _get_coord_dim_map(coords, dims):
 
     def _get_coord(coord):
         """Get a coordinate from various inputs."""
+        # A CoordRange is already canonical (it is the evenly-sampled
+        # representation), so re-parsing it via model_dump -> get_coord is pure
+        # overhead; return it directly. Other coord types are NOT short-circuited:
+        # array coords (CoordArray/CoordMonotonicArray) can be left non-canonical
+        # by slicing (e.g. an evenly spaced subset that should collapse to a
+        # CoordRange), and a fully-specified CoordPartial should canonicalize to a
+        # CoordRange -- get_coord performs that inference.
+        if isinstance(coord, CoordRange):
+            return coord
         if hasattr(coord, "model_dump"):
             coord = coord.model_dump(exclude_defaults=True)
         if isinstance(coord, Mapping):  # input is a dict