Skip to content

Fix ty diagnostics from the crossed #833/#845 merges #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-chambers merged 1 commit into from
Aug 10, 2026
Merged

Fix ty diagnostics from the crossed #833/#845 merges #851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion dascore/utils/chunk_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,11 @@ def _output_dtypes(sub: pd.DataFrame, members: pd.DataFrame) -> pd.Series | None
return None
by_patch = sub.drop_duplicates("_patch_id").set_index("_patch_id")["_dtype"]
grouped = members.groupby("output_id")["_patch_id"]
dtypes = grouped.apply(lambda pids: _combined_dtype(by_patch.reindex(pids)))
# A scalar-returning apply on a SeriesGroupBy is always a Series; the
# stubs cannot see through the lambda and claim DataFrame | Series.
dtypes: pd.Series = grouped.apply( # ty: ignore[invalid-assignment]
lambda pids: _combined_dtype(by_patch.reindex(pids))
)
# "" is the same not-known sentinel ingest writes; never leave NaN,
# which would reach the derived catalog as the string "nan".
return dtypes.map(lambda x: "" if x is None else str(x))
Expand Down Expand Up @@ -901,6 +905,9 @@ def build_chunk_plan(
out_frames.append(outputs)
member_frames.append(members)
if size_diagnostics:
# Diagnostics are only collected on the size-chunk path, where the
# chunk value is an information Quantity (is_data_size gated).
assert isinstance(value, Quantity)
params["size"] = {
"requested_bytes": get_byte_count(value),
"partitions": tuple(size_diagnostics),
Expand Down
Loading