Draw lane membership as a row with no value - #963
Conversation
|
Warning Review limit reached
Next review available in: 36 minutes Limit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughMembership lanes now use missing values instead of booleans. Unvalued lanes render all intervals with the same opaque color. Boolean values receive normal labels and raise ChangesMembership lane semantics
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… lane A frame of mixed lanes spells a missing value as NaN; the inventory path plot hands the lanes such a frame.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #963 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 195 197 +2
Lines 25268 26176 +908
==========================================
+ Hits 25268 26176 +908
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Dev is red after #952 and #955 crossed: #955 made labels refuse
True/False(membership is a row with no value; an interval outside the group has no row), while #952's lanes plot and its tests still drew booleans.tests/test_viz/test_lanes.pyand everytest_inventory_viz.pytest using thenoisyfixture label fail on dev withGot True, but true and false are not values.This brings the lanes plot onto the #955 rule: a row with no value states membership and takes the lane's one colour; the "False drawn faintly" case is gone, because such an interval has no row. The fixtures and the
plot_lanesdocstring example follow, and a test pins that booleans are refused.Changelog
plot_lanes, inventory epoch panels) and its tests for labels that refuse booleans, so the dev test suite is green again.Checklist
I have:
docs/contributing/general_guidelines.qmd).I have (if applicable):