Skip to content

feat(ranking): integrate persisted monthly ranking - #21

Open
DAVstudy wants to merge 2 commits into
mainfrom
feat/t11-final-integration
Open

DAVstudy wants to merge 2 commits into
mainfrom
feat/t11-final-integration

Conversation

@DAVstudy

Copy link
Copy Markdown
Owner

Closes #10

Summary

  • Integrate the two T11 ranking slices that did not reach main when the stacked child PRs were merged into their parent feature branches.
  • Add persisted store/month ranking construction and latest audited tie-resolution readback.
  • Add organizer tie-resolution recording with trusted timestamps and complete documentation.

Changes

File Change
src/modules/ranking/build-store-monthly-ranking.ts Builds rankings from persisted store/month tournament data and applies the latest valid tie revision.
src/modules/ranking/build-store-monthly-ranking.test.ts Covers scoring, invitations, continuity, isolation, and audited readback.
src/modules/ranking/record-store-tie-break-resolution.ts Derives and records the actual Top Cut boundary tie.
src/modules/ranking/record-store-tie-break-resolution.test.ts Covers valid recording and rejection without side effects.
src/modules/ranking/resolve-top-cut-tie.ts Exposes resolver contracts required by the application layer.
README.md Documents persisted ranking and audited corrections.

Test plan

  • TypeScript typecheck passes.
  • Full Vitest suite passes: 79/79 across 12 files.
  • Original slices passed focused tests and independent high-risk verification.
  • Original ranking slice passed native review and acknowledgement.
  • Integration candidate assessment returned medium / under_budget; no additional native review was due.
  • git diff --check passes.

Contributor checklist

  • Linked an approved issue.
  • Added exactly one type:* label.
  • No shell scripts changed; shellcheck is not applicable.
  • Behavior is covered by focused and full-suite tests.
  • Documentation is updated for changed behavior.
  • Commits use Conventional Commit format.
  • No Co-Authored-By trailers.

Integration recovery

PR #18 reached main, but PR #19 merged into feat/t11-audit-persistence and PR #20 merged into feat/t11-persisted-ranking. This PR replays only the two missing reviewed slices on top of current main.

Field Value
Historical chain #18 → #19 → #20
Current PR Final integration recovery
Base main
Depends on #18, already merged
Review budget 801 changed lines / 400
Size exception Explicitly approved because this restores two previously reviewed cohesive slices after the chain was merged into intermediate branches
Starts at main with audited persistence from #18
Ends with Complete T11 persisted ranking and audited tie-resolution flow

Scope

  • Includes: only the ranking and tie-recording slices missing from main.
  • Excludes: public ranking projection, authentication sessions, TOM import, and UI.

@DAVstudy DAVstudy added the type:feature Nueva funcionalidad label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature Nueva funcionalidad

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calcular y resolver la clasificación desde datos persistidos

1 participant